Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Investigate: 💥 Crash 💥 createOption #11004

Closed
melvin-bot bot opened this issue Sep 15, 2022 · 10 comments
Closed

[$250] Investigate: 💥 Crash 💥 createOption #11004

melvin-bot bot opened this issue Sep 15, 2022 · 10 comments
Assignees
@mananjadhav @NicMendonca @mountiny
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Sep 15, 2022 •
edited
Loading

Firebase has reported a new crash that we need to fix, here are all the details we found:

Non-fatal Exception: JavaScriptError

Cannot read property 'avatar' of undefined

main.jsbundle:177314:90 line 177314 createOption

Number of Crashes: 18

Device Information

  • Platforms: Android, iOS
  • App Versions: 1.2.0.3, 1.2.0-3, 1.2.11-2
  • Devices: samsung SM-G950F 9, samsung SM-G973W 11, Apple iPhone14,2 15.5.0

Stacktraces

Android 1.2.11-2 
.anonymous
._callTimer
.callTimers
.apply
.__callFunction
.anonymous
.__guard
.callFunctionReturnFlushedQueue
Android 1.2.0-3 
.createOption
.anonymous
.each
.getOptions
.getSidebarOptions
.getRecentReportsOptionListItems
.apply
.memoized
.render
.finishClassComponent
.updateClassComponent
.beginWork
.performUnitOfWork
.workLoopSync
.renderRootSync
.performSyncWorkOnRoot
.flushSyncCallbacks
.scheduleUpdateOnFiber
.enqueueSetState
.anonymous
.setWithOnyxState
.sendDataToConnection
.anonymous
.tryCallOne
.anonymous
.apply
.anonymous
._callTimer
._callReactNativeMicrotasksPass
.callReactNativeMicrotasks
.__callReactNativeMicrotasks
.anonymous
.__guard
.flushedQueue
.invokeCallbackAndReturnFlushedQueue
iOS 1.2.0.3 
createOption (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:177314:90:177314)
anonymous (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:177466:41:177466)
each (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:83303:19:83303)
getOptions (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:177418:29:177418)
getSidebarOptions (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:177723:22:177723)
getRecentReportsOptionListItems (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:248003:64:248003)
apply
memoized (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:248161:38:248161)
render (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:248022:67:248022)
finishClassComponent (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:7172:128:7172)
updateClassComponent (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:7163:32:7163)
beginWork$1 (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:9120:212:9120)
performUnitOfWork (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:8717:27:8717)
workLoopSync (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:8706:24:8706)
renderRootSync (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:8688:21:8688)
performSyncWorkOnRoot (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:8410:36:8410)
flushSyncCallbacks (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:5205:32:5205)
scheduleUpdateOnFiber (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:8180:530:8180)
enqueueSetState (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:5585:38:5585)
anonymous (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:1519:33:1519)
setWithOnyxState (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:95341:26:95341)
sendDataToConnection (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:81791:47:81791)
anonymous (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:81839:38:81839)
tryCallOne (/Users/distiller/react-native/sdks/hermes/build_iphoneos/lib/InternalBytecode/InternalBytecode.js:53:16:53)
anonymous (/Users/distiller/react-native/sdks/hermes/build_iphoneos/lib/InternalBytecode/InternalBytecode.js:139:27:139)
apply
anonymous (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:11535:26:11535)
_callTimer (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:11447:17:11447)
_callReactNativeMicrotasksPass (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:11474:17:11474)
callReactNativeMicrotasks (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:11678:44:11678)
__callReactNativeMicrotasks (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:3217:46:3217)
anonymous (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:3092:45:3092)
__guard (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:3200:15:3200)
flushedQueue (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:3091:21:3091)
invokeCallbackAndReturnFlushedQueue (/Users/runner/Library/Developer/Xcode/DerivedData/NewExpensify-hgyiprpybmjyfbgfhddtlxzmjjny/Build/Intermediates.noindex/ArchiveIntermediates/NewExpensify/BuildProductsPath/Release-iphoneos/main.jsbundle:3084:33:3084)
Internal Firebase Info

💥 DO NOT EDIT THIS SECTION 💥

Crash IDs: de729788f9edff1f49f15d0662312d6c, 6fd281c28429b9bd424e6530ec68b4bf, 2e3e40c461a7db084eb3bac7d21d1509
Exception: Cannot read property 'avatar' of undefined
@melvin-bot melvin-bot bot added Daily KSv2 External Added to denote the issue can be worked on by a contributor labels Sep 15, 2022
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 15, 2022

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@NicMendonca
Copy link
Contributor

Job post: https://www.upwork.com/jobs/~0163ed1079bdd2f443

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 15, 2022
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 15, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 15, 2022
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 15, 2022

Triggered auto assignment to @mountiny (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Investigate: 💥 Crash 💥 createOption [$250] Investigate: 💥 Crash 💥 createOption Sep 15, 2022
@mountiny
Copy link
Contributor

cc @francoisl The app version in this crash are staging apps, this might be another deploy blocker if we haven't fixed this somewhere else 😬 It is getting to EOD for me so I am afraid I wont be able to dig into this right now

@parasharrajat
Copy link
Member

@mountiny I noticed, that Android stack traces are broken. There is no line number info.

@mountiny
Copy link
Contributor

Oh yeah, interesting, I will create an internal issue for that, thanks!

@francoisl
Copy link
Contributor

Oh yeah so it did create an issue for that, huh. It didn't show up in firebase for some reason.

Anyway, I think this issue should be fixed now, with #11006. The error Cannot read property 'avatar' of undefined is the same that I had found in the logs in #11003 (comment)

@mountiny mountiny added Reviewing Has a PR in review and removed Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 15, 2022
@mountiny
Copy link
Contributor

Wohoo, nice to see this one is probably almost there, gonna keep this one open for a bit and see if new app versions will start coming in

@mountiny
Copy link
Contributor

Closing, nothing new, must have been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mananjadhav mananjadhav

@NicMendonca NicMendonca

@mountiny mountiny

Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@francoisl @mananjadhav @parasharrajat @NicMendonca @mountiny