Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$8000] Investigate: 💥 Crash 💥 com.facebook.react.uimanager.ViewGroupManager.addView #11104

Closed
melvin-bot bot opened this issue Sep 19, 2022 · 28 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2022

Firebase has reported a new crash that we need to fix, here are all the details we found:

Fatal Exception: java.lang.IllegalStateException

java.lang.IndexOutOfBoundsException: index=1 count=0

ViewGroupManager.java line 37 com.facebook.react.uimanager.ViewGroupManager.addView

Number of Crashes: 1

Device Information

  • Platforms: Android
  • App Versions: 1.2.0-4
  • Devices: Xiaomi MI MAX 3 10

Stacktraces

Android 1.2.0-4
com.facebook.react.bridge.ReactContext.handleException (ReactContext.java:429)
com.facebook.react.bridge.ReactContext$ExceptionHandlerWrapper.handleException (ReactContext.java:436)
com.facebook.react.bridge.GuardedRunnable.run (GuardedRunnable.java:32)
android.os.Handler.handleCallback (Handler.java:883)
android.os.Handler.dispatchMessage (Handler.java:100)
android.os.Looper.loop (Looper.java:224)
android.app.ActivityThread.main (ActivityThread.java:7562)
java.lang.reflect.Method.invoke
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:539)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:950)

Internal Firebase Info

💥 DO NOT EDIT THIS SECTION 💥

Crash IDs: 3726e8c3029fce9bad93718c70e3cd7c
Exception: java.lang.IndexOutOfBoundsException: index=1 count=0

@melvin-bot melvin-bot bot added Daily KSv2 External Added to denote the issue can be worked on by a contributor labels Sep 19, 2022
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 19, 2022

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added the Overdue label Sep 22, 2022
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 23, 2022

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@adelekennedy
Copy link

internal
external

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2022
@adelekennedy adelekennedy added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Sep 26, 2022
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 26, 2022

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 26, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 26, 2022
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 26, 2022

Triggered auto assignment to @tgolen (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Investigate: 💥 Crash 💥 com.facebook.react.uimanager.ViewGroupManager.addView [$250] Investigate: 💥 Crash 💥 com.facebook.react.uimanager.ViewGroupManager.addView Sep 26, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 28, 2022
@tgolen
Copy link
Contributor

tgolen commented Sep 28, 2022

Still looking for proposals

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 28, 2022
@tgolen
Copy link
Contributor

tgolen commented Oct 3, 2022

Still ^

@melvin-bot melvin-bot bot removed the Overdue label Oct 3, 2022
@tgolen
Copy link
Contributor

tgolen commented Oct 3, 2022

I think the price of this should double @adelekennedy ?

@adelekennedy adelekennedy changed the title [$250] Investigate: 💥 Crash 💥 com.facebook.react.uimanager.ViewGroupManager.addView [$500] Investigate: 💥 Crash 💥 com.facebook.react.uimanager.ViewGroupManager.addView Oct 4, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 6, 2022
@adelekennedy
Copy link

Still waiting on proposals

@melvin-bot melvin-bot bot removed the Overdue label Oct 6, 2022
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 10, 2022

@tgolen, @mananjadhav, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 10, 2022
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 13, 2022
@adelekennedy
Copy link

Doubling again!

@melvin-bot melvin-bot bot removed the Overdue label Oct 17, 2022
@adelekennedy adelekennedy changed the title [$1000] Investigate: 💥 Crash 💥 com.facebook.react.uimanager.ViewGroupManager.addView [$2000] Investigate: 💥 Crash 💥 com.facebook.react.uimanager.ViewGroupManager.addView Oct 17, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 19, 2022
@adelekennedy
Copy link

waiting on proposals but not time to double yet

@melvin-bot melvin-bot bot removed the Overdue label Oct 20, 2022
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 24, 2022

@tgolen, @mananjadhav, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Oct 24, 2022
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 24, 2022

@tgolen, @mananjadhav, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

@tgolen
Copy link
Contributor

tgolen commented Oct 24, 2022

Still no proposals. It's fine to let this keep doubling.

@melvin-bot melvin-bot bot removed the Overdue label Oct 24, 2022
@adelekennedy
Copy link

Doubling time!

@adelekennedy adelekennedy changed the title [$2000] Investigate: 💥 Crash 💥 com.facebook.react.uimanager.ViewGroupManager.addView [$4000] Investigate: 💥 Crash 💥 com.facebook.react.uimanager.ViewGroupManager.addView Oct 24, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 27, 2022
@tgolen
Copy link
Contributor

tgolen commented Oct 27, 2022

Waiting for proposals still

@melvin-bot melvin-bot bot removed the Overdue label Oct 27, 2022
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 31, 2022

@tgolen, @mananjadhav, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2022
@mananjadhav
Copy link
Collaborator

Still waiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label Oct 31, 2022
@adelekennedy
Copy link

And we're doubling again!

@adelekennedy adelekennedy changed the title [$4000] Investigate: 💥 Crash 💥 com.facebook.react.uimanager.ViewGroupManager.addView [$8000] Investigate: 💥 Crash 💥 com.facebook.react.uimanager.ViewGroupManager.addView Oct 31, 2022
@Justicea83
Copy link
Contributor

Justicea83 commented Oct 31, 2022

The crash doesn't have enough context, I did a bit of digging and realized it has to do with the zIndex of views. Saw an SO here. The error is coming from here.

@mananjadhav
Copy link
Collaborator

Thanks @Justicea83.

A couple of things here,

  1. I spent time in digging the root cause, trying to reproduce but I couldn't. We have a similar issue for zIndex property here

@adelekennedy @tgolen Coming from this thread it mentions we cap the Crash 💥 issues for $500. I know @tgolen mentioned earlier no caps. But wanted to double check if we should be doubling it?

  1. Another question, does the Number of Crashes update when multiple crashes are reported? Currently it says 1, and the version as 1.2.0-4, where as we're at: v1.2.21-4. Do you think closing this out might also be an option?

@tgolen
Copy link
Contributor

tgolen commented Nov 2, 2022

Do you think closing this out might also be an option?

I think we can close it if there hasn't been any more instances of the crash. I looked in Crashlytics and found that this crash only happened once on Sep 19, and hasn't happened since. Because of that, I am going to close this issue.

@tgolen tgolen closed this as completed Nov 2, 2022
@tgolen
Copy link
Contributor

tgolen commented Nov 2, 2022

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

5 participants