Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Connect bank account - The system returns to the previous page after returning online #11368

Closed
kbecciv opened this issue Sep 28, 2022 · 6 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Sep 28, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #10987

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
    and login with any account
  2. Go to Settings>Workspace>Connect Bank Account
  3. Select "Connect Manually"
  4. Go offline
  5. Restore internet connection

Expected Result:

The system should stay on the same page

Actual Result:

The system returns to the previous page

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.8.0

Reproducible in staging?: Yes

Reproducible in production?: n/a

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5752696_Recording__2104.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Sep 28, 2022

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@AndrewGable
Copy link
Contributor

I'm not 100% sure this is a bug, do we have a test stating that it should stay on the same page? cc-ing a few others for some opinions @luacmartins @ctkochan22 @Julesssss

@Julesssss
Copy link
Contributor

I'm not sure either, but I'm leaning towards 'bug', as it would be annoying to be kicked out of the flow if you temporarily lose connection after typing in your bank details.

@luacmartins
Copy link
Contributor

I'm pretty sure this is a bug. We are supposed to override the server response with the locally stored step and subStep here. However, we set the reimbursementAccount key here which empties both step and subStep. I put up a draft PR, if you wanna take a look.

@luacmartins
Copy link
Contributor

That being said, these two statements seem conflicting to me:

We are using set here since we will rely on data from the server (not local data) to populate the VBA flow and determine which step to navigate to.

If we already have a substep stored locally then we will add that to the new achData

@luacmartins
Copy link
Contributor

Nvm my comment above, I think they make sense as in we use server data for step but we can use local data for subStep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants