[HOLD #11768] mWeb-lands on wrong screen when pressing the back button from the attachment screen @gadhiyamanan

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with any account
3. Go to any chat
4. Click on any attachment
5. Press back button

Expected Result:

Should navigate to chat screen

Actual Result:

Navigate to home screen

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web

Version Number: 1.2.8.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220913_134105_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663057441323579

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @alexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[thesahindia]

Dupe of #7010 and it was decided to close it (check the reason here)

[alexpensify]

Assigning to Engineering for the check if this one should be closed or give it another review.

cc: @roryabraham and @stitesExpensify

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[stitesExpensify]

Hmm so the problem is that the attachment picker is not really a new page, it's the same page with a modal on it, so the back button is technically functioning correctly. IMO this is not a bug, it's user error. If they hit the x everything will work fine. The only reason it's confusing is because it looks like a different page, but that's not something we want to fix right now IMO

[stitesExpensify]

If we do want to fix this, we could artificially add the report page a second time to react-navigation, but that could also cause problems where the flow is:

1. Navigate to report
2. Hit add attachment
3. Click the x
4. Hit back button
5. You stay on the same page
6. Hit back again and you actually go back.

So we would need to artificially add it when you click "add attachment" and then remove it when you hit the "x". Again I think that's not worth it though, happy to hear other opinions

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[roryabraham]

cc @puneetlath because this is react-navigation related I'm thinking we should put it on HOLD pending the FT you're working on

[cristipaval]

removed the assignment since I see you guys are already triaging it. Thanks!

[roryabraham]

Putting this on HOLD and added to tracking issue: https://github.com/Expensify/Expensify/issues/221853

(sorry, this tracking issue is internal)

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Triggered auto assignment to @slafortune (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[JmillsExpensify]

Switching out the weekly for monthly given that the navigation project is large and has no ETA.

[JmillsExpensify]

Still on hold for the navigation project.

[JmillsExpensify]

Same same.

[JmillsExpensify]

Still on hold.

[JmillsExpensify]

Still on hold

[JmillsExpensify]

Coming off hold very soon!

[mountiny]

This is not its own screen so I dont think this will be fixed and I am not sure if we should be fixing it in terms of consistency wit desktop. There the attachment is also a modal and not its own page.

[JmillsExpensify]

Ok cool, still aiming to get to this one this week.

[JmillsExpensify]

Still trying to make time. Low priority.

[JmillsExpensify]

Re-tested and this is now fixed.

[JmillsExpensify]

@gadhiyamanan I just sent you an offer for reporting. Once you've accepted and been paid, we can close this one out.

[gadhiyamanan]

@JmillsExpensify offer accepted, thanks!

[JmillsExpensify]

Anytime. All paid out!