-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hold #11768] mWeb- Connect Bank Account - Pressing back button at android in the middle of a step takes you back to the workspace page instead of going back to the previous step @Puneet-here #11429
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
I don't have an android phone, but worked with @pecanoro to reproduce this in an android device. |
Discussing ideal behavior for how this should work here. |
Triggered auto assignment to @MariaHCD ( |
Demoting priority and adding to project: https://github.com/Expensify/App/projects/2 |
Triggered auto assignment to @tjferriss ( |
I'm not able to reproduce this on web staging (v1.2.18-2) or on my iPhone app (v1.2.15-3). I am successfully taken back to the previous step. Are we sure this is still broken? |
Hi @tjferriss, it's still reproducible. You have to repro this on Android and you will need to press native back button. |
Still on hold for the navigation reboot. |
Same same |
Still on hold. |
Still on hold. |
Coming off hold very soon! |
Working on testing this week. |
Still trying to make time. Low priority. |
@Puneet-here do you mind re-testing this one and confirming that it's no longer an issue? At that point we can pay you for reporting the issue. |
It's still reproducible. |
Thanks! @mountiny is the BBA flow potentially a special case that we didn't cover for the react-navigation project? Perhaps just as relevant: What's the expected behavior for a multi-step flow in a modal? Just thinking generally on this, I'm kind of doubting that each step has it's own route, and thus back would correctly close the modal. |
Yeah this is because each step is most likely not its own screen. I think however we can close this since this project will probably change this completely https://docs.google.com/document/d/1t8_Fn93LSSU4gG4z7WRt8IFcpSGK4TIe4QamdcTXjxE/edit?usp=sharing |
Ok cool. I'll still go ahead and pay out @Puneet-here for reporting, since we will fix this. |
Offer sent. Please accept and we can get this closed out @Puneet-here! |
Accepted! |
All paid out! Thank you, have a great weekend. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
ou should be navigated back to the previous step
Actual Result:
You will be navigated to the workspace page
Workaround:
Unknow
Platform:
Where is this issue occurring?
Version Number: 1.2.9.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2022-09-22.at.2.04.27.AM.mov
Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1663792588717789
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: