[HOLD #11768] - Pressing X closes the chat in mobile web reported by @Puneet-here

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to concierge > Tap on call icon
2. Press X

Expected Result:

Request call page should close

Actual Result:

The chat also closes

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web

Version Number: 1.2.9-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

195459189-210ac871-cbb0-4ea0-9b05-d940956bbf63.mp4

IUYK1536.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1664280561381979

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[Puneet-here]

Proposal

Just pasting my proposal here from the slack thread

Remove true from the lines below

App/src/pages/NewChatPage.js

Line 220 in c942b3e

onCloseButtonPress={() => Navigation.dismissModal(true)}

App/src/pages/RequestCallPage.js

Line 255 in c942b3e

onCloseButtonPress={() => Navigation.dismissModal(true)}

App/src/pages/SearchPage.js

Line 175 in c942b3e

onCloseButtonPress={() => Navigation.dismissModal(true)}

[melvin-bot]

@michaelhaxhiu Whoops! This issue is 2 days overdue. Let's get this updated quick!

[michaelhaxhiu]

cc @puneetlath another navigation issue here.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[michaelhaxhiu]

@kavimuru can you re-upload your video please?

Meanwhile, I pinged @puneetlath for a Q on how to handle this navigation issue. I suspect we keep it on hold. But want to ensure it's linked properly.

[michaelhaxhiu]

Once we get a video, I'll add this to #11768

[kavimuru]

@michaelhaxhiu added new videos

[michaelhaxhiu]

Nice, thank you!

[melvin-bot]

Triggered auto assignment to @tjferriss (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[JmillsExpensify]

Switching out weekly for monthly given that navigation project is larger and has no defined ETA.

[JmillsExpensify]

Still hold on the navigation reboot.

[JmillsExpensify]

Same same.

[JmillsExpensify]

Still on hold

[JmillsExpensify]

Still on hold

[JmillsExpensify]

Coming off hold very soon!

[JmillsExpensify]

Working on testing this week.

[JmillsExpensify]

Still trying to make time. Low priority.

[JmillsExpensify]

So for this one, we ended up deprecating this flow. Given that we accepted this bug at the time, I'm going to award the bug bounty.

[JmillsExpensify]

@Puneet-here Offer sent. Please let me know when you've accepted and we'll get this one paid out.

[Puneet-here]

Accepted!

[JmillsExpensify]

Thanks! Offer paid.