Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments - List of payments is blinking when navigate fro sign in to Payments #11460

Closed
kbecciv opened this issue Sep 30, 2022 · 23 comments
Closed
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Sep 30, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Precondition: Log out from account

  1. Launch the app
  2. Log in with the same expensifail account
  3. Go to Setting - Payments

Expected Result:

List of payments is not blinking when navigate fro sign in to Payments

Actual Result:

List of payments is blinking when navigate fro sign in to Payments

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.10.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

10447.Andriod.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Sep 30, 2022

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@nkuoch
Copy link
Contributor

nkuoch commented Sep 30, 2022

cc @ctkochan22 should we show a loader while we're fetching?

@nkuoch nkuoch added the Internal Requires API changes or must be handled by Expensify staff label Sep 30, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2022
@ctkochan22
Copy link
Contributor

Yes that sounds like a good idea

@melvin-bot melvin-bot bot removed the Overdue label Oct 3, 2022
@ctkochan22
Copy link
Contributor

This was originally discussed to be this way I think. Under pattern none for offline behavior. So we should add a loader if we are online and fetching. And still do nothing otherwise

@ctkochan22
Copy link
Contributor

How does this look?
ktjXcWm4GB

@ctkochan22 ctkochan22 added the Reviewing Has a PR in review label Oct 4, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2022

@nkuoch, @ctkochan22 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Oct 14, 2022

@nkuoch, @ctkochan22 Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

@nkuoch, @ctkochan22 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2022

@nkuoch, @ctkochan22 10 days overdue. Is anyone even seeing these? Hello?

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 25, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2022

This issue has not been updated in over 14 days. @nkuoch, @ctkochan22 eroding to Weekly issue.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Nov 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 17, 2022

This issue has not been updated in over 15 days. @nkuoch, @ctkochan22 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@ctkochan22 ctkochan22 added Weekly KSv2 and removed Monthly KSv2 labels Nov 17, 2022
@ctkochan22
Copy link
Contributor

Merged main, needs a few changes

@flodnv flodnv added Daily KSv2 and removed Weekly KSv2 labels Nov 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 29, 2022

@nkuoch, @ctkochan22 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Dec 1, 2022

@nkuoch, @ctkochan22 Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented Dec 5, 2022

@nkuoch, @ctkochan22 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Dec 8, 2022

@nkuoch, @ctkochan22 12 days overdue. Walking. Toward. The. Light...

@nkuoch nkuoch removed their assignment Dec 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 16, 2022

@ctkochan22 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Dec 20, 2022

@ctkochan22 Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Dec 22, 2022

@ctkochan22 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Dec 26, 2022

@ctkochan22 12 days overdue. Walking. Toward. The. Light...

@melvin-bot melvin-bot bot removed the Daily KSv2 label Dec 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 29, 2022

This issue has not been updated in over 14 days. @ctkochan22 eroding to Weekly issue.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Dec 29, 2022
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Feb 6, 2023
@MelvinBot
Copy link

This issue has not been updated in over 15 days. @ctkochan22 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@ctkochan22
Copy link
Contributor

Woah wierd, fixed here: #11592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants