App crashes when trying to open IOU details - reported by @adeel0202

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Break down in numbered steps

1. Open any chat with IOU
2. Click on View details to open details

Expected Result:

Describe what you think should've happened

1. IOU details open

Actual Result:

Describe what actually happened

1. App crashes

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

No

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: v1.2.13-2 (Staging)
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @adeel0202
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665579836146209

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

I am getting report action which is undefined

I have narrowed down the issue to the react-onyx-bump in which we have refactored the way we merge stuff and it seems like mergeCollection action is not working as expected or as it worked before this change. Expensify/react-native-onyx#186

coming from this PR #11723

[mountiny]

cc @Szymon20000 @luacmartins

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

Actually sorry @Szymon20000 this is failing with version .18 in which your PR hasnt been published yet so this must be coming from Expensify/react-native-onyx#179 cc @marcaaron

[adeel0202]

@mountiny I'm expecting reporting bonus.

[mountiny]

it closes automatically when the PR is merged, reopening.

[michaelhaxhiu]

https://www.upwork.com/jobs/~01dadf0587f9dca0fe

[adeel0202]

@michaelhaxhiu I have applied.

[michaelhaxhiu]

Paid.

[marcaaron]

What about the changes in Onyx broke merging? Can you leave some more detailed investigation here?

[marcaaron]

@vitHoracek @luacmartins

[tgolen]

Yeah, I think we should be actively looking to figure out what is broken in Onyx and fixing it at the source rather than just reverting it.

[mountiny]

I completely agree, I have opted for quicker solution as I did not see clearly what is wrong and it was getting toward the end of the day. Since the revert fixed it, I opted for that.

Good job spotting the key issue @marcaaron

[luacmartins]

Agreed! @marcaaron FYI that is the wrong GH handle for @mountiny 😄

[mountiny]

Haha, thanks, the other account is also me and I get email notifications for those tags so I wont miss it :D knew this would happen