[$250] Web - Reimburse expenses - Offline save changes are not reflected immediately

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to Settings->Workspace-Reimburse expenses
4. Kill the internet connection
5. Change the parameters for Rate and Unit
6. Turn on the internet connection

Expected Result:

Offline save changes should be reflected immediately

Actual Result:

It flashes to old values for a second, then the value remains unchanged

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.15.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5775963_Recording__2365.mp4

198854259-e9e48603-dae1-4992-a5ee-e75809ac5b4a.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[chiragsalian]

Shall investigate today

[chiragsalian]

I can reproduce the issue on staging but not on dev. From the network request it looks like the issue is something related to persisted requests and may not necessarily be an issue with the code around rate and unit. Either way, I'm thinking of waiting to see if the next deploy just solves this issue. Demoting it to weekly till then.

[chiragsalian]

I retested and it looks like its not an issue anymore. Can you retest and confirm @kbecciv?

[kbecciv]

@puneetlath Checking, will update you shortly

[kavimuru]

@chiragsalian It flashes to old values for a second, then the value remains unchanged. Please check this video.

Recording.817.mp4

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[chiragsalian]

Ah yes, i see that problem. @kavimuru, could you update this issue or create another one to reflect the issue you just mentioned with steps. Then I can apply the external label so someone else can also reproduce and tackle.

[kavimuru]

@chiragsalian I have edited the steps, as per this new issue.

[chiragsalian]

Sounds good. I'm like 90% sure the problem is front end and it might be an issue with how PersistedRequests and reconnectApp works. Either way, adding the appropriate labels for people to investigate.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Current assignee @chiragsalian is eligible for the External assigner, not assigning anyone new.

[MitchExpensify]

Upwork Job

[tienifr]

Proposal

Problem

Currently, in offline mode when the user edits the init rate and clicks save, this action will add in networkRequestQueue and will be called back if back online.
When comeback online, firstly api?command=OpenWorkspaceReimburseView will be called to refresh data (old data) and then api?command= UpdateWorkspaceCustomUnitRate to update Workspace Custom Unit Rate. So when saving changes in offline are not reflected immediately

Solution

In Expensify/App/src/libs/actions/Policy.js
we'll change the read method to the write method to add api?command= OpenWorkspaceReimburseView to SequentialQueue to call synchronous

- API.read('OpenWorkspaceReimburseView', {policyID});
+ API.write('OpenWorkspaceReimburseView', {policyID});

Before

Screen-Recording-2022-11-02-at-11.27.10.mp4

After

Screen-Recording-2022-11-02-at-11.23.24_1.mp4

[parasharrajat]

I think we prioritized write operations before Reading in some PR. So this should be fixed by that.

I will discuss this on slack on Monday(when the team is active).

[jasperhuangg]

This issue is solved by #12219, closing