Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - LHN - App is crashed when tap on Send/Request money #12173

Closed
kbecciv opened this issue Oct 27, 2022 · 15 comments
Closed

Android - LHN - App is crashed when tap on Send/Request money #12173

kbecciv opened this issue Oct 27, 2022 · 15 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 27, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with any account
  3. Tap on Fub menu
  4. Tap Send/Request money

Expected Result:

User can procced with request/send money flow

Actual Result:

App is crashed when tap on Send/Request money

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.2.20.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20221026-210419_New.Expensify.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 27, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2022

Everybody was OOO, so I assigned 10 random eligible people.

@rafecolton
Copy link
Member

rafecolton commented Oct 27, 2022

For some context on "10 random eligible people" being assigned: https://expensify.slack.com/archives/C03TQ48KC/p1666842111537709?thread_ts=1666838060.530049&channel=C03TQ48KC&message_ts=1666842111.537709

@Gonals
Copy link
Contributor

Gonals commented Oct 27, 2022

Hmmm. I can't seem to reproduce the issue. What about the rest of you?

@techievivek
Copy link
Contributor

techievivek commented Oct 27, 2022

Me neither.
Screenshot_20221027-144033

@Julesssss Julesssss self-assigned this Oct 27, 2022
@Julesssss
Copy link
Contributor

I can't reproduce the crash on this page, but I'm seeing a crash every time I open the app and stay on the LHN page. Both on a Pixel 4a Android 13 and Nexus 5X Android 8.1

screen-20221027-103121.mp4

@Julesssss
Copy link
Contributor

I can only reproduce this on version 1.2.20-0. Possibly triggered by the reanimated library, which for some reason is passing a null reference to a Double conversion function in the Java library. I'm going to look further into this, but likely will suggest that we simply revert the PR that introduced this -- it's a pretty major regression.

Logs
Screenshot 2022-10-27 at 10 41 54

Likely cause of crash
Screenshot 2022-10-27 at 10 52 32

@kbecciv
Copy link
Author

kbecciv commented Oct 27, 2022

@Julesssss Can someone confirm if the console error on Web the same root cause of this issue, or we need to log separate?

image (20)

Also when creating a new chat/group conversation

image (21)

@melvin-bot melvin-bot bot closed this as completed Oct 27, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2022

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@bondydaa
Copy link
Contributor

hmm crap sorry didn't reload this page before trying to un-assign myself

@marcaaron
Copy link
Contributor

I'm also seeing a crash similar to this on main and it's blocking me from testing a PR to update react-native-onyx to the latest version.

Should we re-open? Seems not fixed.

@marcaaron
Copy link
Contributor

2022-10-27_10-19-11

Happens when inviting a new member to a workspace on native Android only

@marcaaron
Copy link
Contributor

@kbecciv those errors look different

@marcaaron
Copy link
Contributor

Gonna try to clean the build folder actually.. 1 sec.

@marcaaron
Copy link
Contributor

nvm definitely was running an out of date build :oh-nothing: thanks for tuning in everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests