Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RN fork to latest #12177

Closed
roryabraham opened this issue Oct 27, 2022 · 5 comments
Closed

Upgrade RN fork to latest #12177

roryabraham opened this issue Oct 27, 2022 · 5 comments
Assignees
Labels

Comments

@roryabraham
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem

A recent commit in the react-native upstream introduced Fabric support for modals. We don't have that code in our fork yet.

Solution

Two parts:

  1. Upgrade and republish our fork (I will do this)
  2. Then upgrade E/App to the new version of the fork (most likely this will shadow 0.70.4, released two days ago) (I will likely make this part external)

View all open jobs on GitHub

@roryabraham
Copy link
Contributor Author

Ran into a snag where this commit has not been included in any upstream release yet

@roryabraham
Copy link
Contributor Author

Going to just manually perform that commit in the Expensify-0.70.4-alpha branch, so that we can get it included in the release without me trying to build off a non-stable release

@roryabraham
Copy link
Contributor Author

Fork has been upgraded, and I published @expensify/react-native@0.70.4-alpha.1, that shadows the upstream 0.70.4. I also added in this commit manually so that we can benefit from that change which hasn't been included in any upstream releases yet.

To clarify, E/App is currently using @expensify/react-native@0.70.5, which (confusingly) shadowed the upstream 0.70.1. Going forward, I'm going to use -alpha.X release suffixes so that our fork versions always shadow the upstream more intuitively.

@roryabraham
Copy link
Contributor Author

@AndrewGable
Copy link
Contributor

PR In review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants