Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Update react-native-svg library once released #12233

Closed
Julesssss opened this issue Oct 28, 2022 · 15 comments
Closed

[$250] Update react-native-svg library once released #12233

Julesssss opened this issue Oct 28, 2022 · 15 comments
Assignees
@Julesssss @isabelastisser
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Task

Comments

@Julesssss
Copy link
Contributor

Currently we point the react-native-svg library to a specific commit. Once this upstream PR is merged and released, we need to bump our version to match it.
@Julesssss Julesssss self-assigned this Oct 28, 2022
@Julesssss Julesssss changed the title Update Update react-native-svg library once released Oct 28, 2022
@Julesssss Julesssss mentioned this issue Nov 2, 2022
Merged
90 tasks
@Julesssss
Copy link
Contributor Author

PR: #12374

@melvin-bot melvin-bot bot closed this as completed Nov 4, 2022
@Julesssss Julesssss reopened this Nov 9, 2022
@Julesssss Julesssss added the External Added to denote the issue can be worked on by a contributor label Nov 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 9, 2022

Triggered auto assignment to @isabelastisser (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 9, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 9, 2022

Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title Update react-native-svg library once released [$250] Update react-native-svg library once released Nov 9, 2022
@Julesssss
Copy link
Contributor Author

Hey @isabelastisser, this is already complete but could we please create an UpWork issue to pay out the contributor for their review? I'm going to assign you to the PR also.

@puneetlath
Copy link
Contributor

@Julesssss To help us clear out the large backlog of /App bugs, we're putting the spotlight every bug in the repo already than 4 weeks old. To help unblock the roadmap and get our bug pipeline back in equilibrium, can you:

  • Decide whether any proposals currently meet our guidelines and can be approved as-is
  • For any that can't, please take this issue internal and treat it as one of your highest priorities
  • If you have any questions, don't hesitate to start a discussion in #bug-zero

@Julesssss
Copy link
Contributor Author

Hi @isabelastisser, could you please create an UpWork issue to pay out @Santhosh-Sellavel please?

@isabelastisser
Copy link
Contributor

Creating an UpWork issue for this job now.

@isabelastisser
Copy link
Contributor

Internal job posting: https://www.upwork.com/ab/applicants/1595083283153248256/job-details

External job posting: https://www.upwork.com/jobs/~017e99e729590faba2

@Santhosh-Sellavel
Copy link
Collaborator

Done @isabelastisser thanks!

@iwiznia iwiznia removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 25, 2022
@Santhosh-Sellavel
Copy link
Collaborator

@isabelastisser bump

@isabelastisser
Copy link
Contributor

Sorry for the delay! Offline now but will make the payment by EOD today.

@isabelastisser
Copy link
Contributor

@Santhosh-Sellavel I sent you the offer in Upwork, please accept it and I will issue the payment. Thanks!

@Santhosh-Sellavel
Copy link
Collaborator

Thanks, Accepted! @isabelastisser

@isabelastisser
Copy link
Contributor

Paid!

The contract ended and the job is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julesssss Julesssss

@isabelastisser isabelastisser

Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@iwiznia @puneetlath @mananjadhav @Julesssss @isabelastisser @Santhosh-Sellavel