[HOLD] [$250] IOS - Settings - Changes displayed after closing and reopen app

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #12125

Action Performed:

1. Launch the app
2. Log in any account
3. Navigate to Settings > Profile
4. Disable the internet connection in the device
5. Modify first name, last name, and your timezone
6. Save and verify everything looks like it updated correctly
7. Click back button to go back to settings page
8. Click profile and verify changes are preserved
9. Click back button to go back to settings page again
10. Go back online
11. Click on the Profile and check

Expected Result:

Changes should be displayed after go back online.

Actual Result:

Changes displayed after closing and reopen app

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.2.22.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1667327839.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

@flaviadefaria Eep! 4 days overdue now. Issues have feelings too...

[flaviadefaria]

Was able to recreate the bug so will create UW job posts.

[melvin-bot]

Current assignee @flaviadefaria is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @mountiny (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[flaviadefaria]

Internal link - https://www.upwork.com/ab/applicants/1589978535629422592/job-details
External link - https://www.upwork.com/jobs/~0189d0bc78f110af85

[mountiny]

Putting this on Hold as I tihnk there is already issue for the settings not being saved correctly

[mountiny]

This is indeed just a regression from #11632

[mountiny]

I will close this one in favour of the original #11632!

[jasperhuangg]

Tried the reproduction steps on dev and it appears to be working, so this might be fixed with the next App deploy, stay tuned..

Screen.Recording.2022-11-08.at.8.35.21.AM.mov

[flaviadefaria]

Cool let's wait for the next deploy before I delete the UW posts.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[mountiny]

Also wasnt able to repro on the latest Staging iOS. @jasperhuangg seems like caught it right.

[mountiny]

We have not been able to reproduce this issue in staging and production anymore. The values save correctly, although in some testing tries the old values flickers/appears temporarily in the product before the correct saved values settle.

This is most likely related to order of the read/write requests which go to the server once we get online #12219

[flaviadefaria]

Closed the UW post!