[HOLD for payment 2023-02-03] [$1000] [Image] The attachment PDF preview is not shown offline reported by @Santhosh-Sellavel

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open any chat in the new dot
2. Go offline
3. Click ➕ in composer -> Add Attachments
4. Select a PDF attachment

Expected Result:

Should show a preview like we show image preview

Actual Result:

Failed to load error

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.24-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

200205740-d1d90f4b-358b-46b2-87d0-5ecdc036711e.mov

Expensify/Expensify Issue URL:
Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1667782878782179

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0101e6d9faf1232624
• Upwork Job ID: 1600152502185627648
• Last Price Increase: 2022-12-08

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[0xmiros]

This issue is reproducible for me on web (both on desktop and on mobile) even when online.

[0xmiros]

I think this is backend issue.
console error:

[melvin-bot]

Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mallenexpensify]

I'm heading OOO, reassigning.

[davidcardoza]

I was able to reproduce this. Assigning an engineer to triage - can this be worked on by an external contributor?

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[joelbettner]

can this be worked on by an external contributor

Yes, I believe this can be worked on by an external contributor.

[melvin-bot]

Current assignee @davidcardoza is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Triggered auto assignment to @sketchydroide (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[JmillsExpensify]

cc @youssef-lr I am kind of thinking that we need to have someone holistically approach all these attachment uploads cases. What do you think about us creating one central issue for all the remaining bugs and improvements we need to make? I'm happy to get it started.

[marcaaron]

I don't think this was a regression was it? There's no real investigation to do. This has just never worked correctly offline.

[marcaaron]

Checked off the first 3 boxes. We should create a test rail step for this though.

[marcaaron]

Think this one is just waiting for payment + regression tests.

[davidcardoza]

payment sent to @aimane-chnaif. @marcaaron is a regression test necessary per your comment here

I don't think this was a regression was it? There's no real investigation to do. This has just never worked correctly offline.

[marcaaron]

Yes, we should create a regression test even though this was not specifically caused by merging another PR.

If I am understanding the BZ checklist instructions here we should. In this case, there was just no specific PR that caused and regression or additional conversation to be had.

I also understand that we changed this recently so it should be responsibility of whoever fixes the issue (which was me 😅) but then BZ is supposed to create the issue to add it to test rail?

Anyway, the steps would be:

1. Open any chat in New Expensify on Web
2. Go offline
3. Click ➕ in composer -> Add Attachments
4. Select a PDF attachment
5. Verify a preview of the PDF can be seen

[davidcardoza]

Ya, admittedly, I have yet to run a regression test, it's a bit unclear to me when a regression test should take place or not. Getting a buddy check here - https://expensify.slack.com/archives/C01SKUP7QR0/p1675814496893819

[davidcardoza]

A regression test was added as the previous test was pretty similar to the offline PDF case in this test case:
https://expensify.testrail.io/index.php?/cases/view/1971194&group_by=cases:section_id&group_order=asc&display_deleted_cases=0&group_id=229062

Updated to:

Offline

1. Open a conversation
2. Go offline
3. Click on the plus sign in composer -> Add Attachments
4. Select a PDF attachment
5. Verify a preview of the PDF can be seen

[Santhosh-Sellavel]

@davidcardoza reporting bonus is missed out here!

[davidcardoza]

@Santhosh-Sellavel offer sent.

[Santhosh-Sellavel]

Thanks @davidcardoza Accepted!

[kbecciv]

Issue is reproductible in build 1.2.87.0

[aimane-chnaif]

@kbecciv I think you tried to preview PDF which was already sent as attachment. This should be impossible scenario. How come user can see online data in offline mode before downloading?
This issue is just to preview local PDF before sending attachment.

[kbecciv]

Yes, you are correct, I'm trying  to preview PDF which was already sent as attachment.

[trjExpensify]

Doesn't this one come down to caching on web/desktop, which is being worked on elsewhere?

[aimane-chnaif]

Doesn't this one come down to caching on web/desktop, which is being worked on elsewhere?

I know image cache is being worked already but I don't think PDF cache is being worked anywhere.

[trjExpensify]

Right, but presumably the work we do to support image caching is going to be extended to other file types? I think @thomas-coldwell has it on his radar as a follow-up.

[marcaaron]

I'm closing this. The original issue is solved. Not sure what issue we are now experiencing on Android, but let's create a new issue to track it with clearer repro steps.

[kbecciv]

@marcaaron Logged a separate issue here #16694