-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Android - Compose box shifts to the top when the keyboard opens #12622
Comments
Part of the Keyboard issue grouping. @JmillsExpensify |
Hey @kavimuru, was the team not able to reproduce this issue? |
@Julesssss None of us have Pixel 6a. Couple testers have android 13 and saw this issue once on (11/07/22) regression and not able to repro after relogin. Asked to keep an eye on it in the next regression (11/08/22) was not able to repro. |
@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@Julesssss Our testers can reproduce this issue Screen_Recording_20221117-105436_New.Expensify.mp4 |
Triggered auto assignment to @CortneyOfstad ( |
@Julesssss Thanks, assigning myself. Not sure why Github just notified me but that's a separate topic. I'll also it is to the tracking issue. |
Creating an Upwork job now and getting this process kicked off. cc @tgolen for visibility |
Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new. |
Job added to Upwork: https://www.upwork.com/jobs/~010a8681fe8590e35d |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new. |
Awaiting proposals |
This is why we need Android for BZ! Luckily Browerstack is coming. |
I tried it on my phone (Samsung A51) it still works fine. I think this problem occurs depending on the device model Screen.Recording.2022-11-19.at.09.02.03.mov |
I'm okay with closing this, but it is still occurring. The problem is that the steps aren't 100% reproducible. After opening the search page, and switching between chats I often see this bug. I reproduced it just a minute ago, but of course as soon as I started recording it didn't occur 🙄 Let's close on the understanding that we don't yet have fully reproducible steps. Something is missing from our current steps and I'm not yet sure what that is. |
Proposal here and still in discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1669197533676619?thread_ts=1669197511.103729&cid=C01GTK53T8Q |
The keyboard issues are wider, and others will need to review that also. |
Agree that the keyboard issues are wider. As for the reproducibility, I think this comes down to whether it's a bug because we can reproduce it on any Android phone, versus wether we can reproduce it on one of the major Android phones in the market (focusing on the US market, because that's where our users overwhelmingly are). |
So specifically speaking to Samsung A51, that phone was announced in December 2019. It's going on three years, which is fine but I think that also makes it harder to optimize for. Then on top of that, we have the much bigger convo on which brands/devices in the Android ecosystem we're going to support and which we aren't. I would say for now we should keep this closed unless we can reproduce on another, either newer or "pure" Android device from Google. |
It was reproducible for me on a brand-new Pixel 6a. Rather than being device specific, I think there are additional requirements to reproduce which we are unaware of. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Thanks added the |
I'm not 100% sure that this is resolved, but based on my work to use adjustResize in the past I believe there's a good chance this PR entirely resolves this issue. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Proper padding should be there between keyboard and compose box
Actual Result:
Compose box shits to the top of the page
Workaround:
unknown
Platform:
Where is this issue occurring?
Version Number:
Reproducible in staging?: Need reproduction
Reproducible in production?: Need reproduction
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
screen-20221108-154218.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Julesssss
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1667922302937219
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: