Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all uses of FetchFreePlanVerifiedBankAccount #12684

Closed
ctkochan22 opened this issue Nov 11, 2022 · 6 comments
Closed

Remove all uses of FetchFreePlanVerifiedBankAccount #12684

ctkochan22 opened this issue Nov 11, 2022 · 6 comments
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@ctkochan22
Copy link
Contributor

Replaced all the uses of FetchFreePlanVerifiedBankAccount in app for the API Refactors: https://github.com/Expensify/Expensify/issues/226858

Now remove all the unused code and tests

@melvin-bot
Copy link

melvin-bot bot commented Nov 15, 2022

@ctkochan22 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@JmillsExpensify
Copy link

Are you still working on the draft PR for this one? When do you think it'll be ready? I'm hoping we can put the Bank / Wallet refactors behind us this week.

@ctkochan22
Copy link
Contributor Author

There is a deploy blocker that may have been caused by one our PRs. I'm currently looking into that before removing methods: #12670

@melvin-bot melvin-bot bot removed the Overdue label Nov 15, 2022
@JmillsExpensify
Copy link

Gotcha, thanks for closing the loop. Makes sense.

@ctkochan22
Copy link
Contributor Author

Blocker might have been due to something else, and we are deploying app. Drawing up this PR now.

@JmillsExpensify
Copy link

Thanks so much for closing the loop here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants