Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Android navigation bar transparent #13087

Closed
Julesssss opened this issue Nov 28, 2022 · 5 comments
Closed

Make the Android navigation bar transparent #13087

Julesssss opened this issue Nov 28, 2022 · 5 comments
Assignees
@Julesssss
Labels
Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Nov 28, 2022 •
edited
Loading

Problem

After merging the dark theme, we realised that the Android navigation bar isn't made transparent and matches the system theme set by the user.

dark

device light mode:

light

Solution

Improve this, with a translucent navigation bar. Hardcoding it (like we currently do for status bar) won't work as we'll soon let the user select a style.
@Julesssss Julesssss added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff labels Nov 28, 2022
@Julesssss Julesssss self-assigned this Nov 28, 2022
@Julesssss Julesssss mentioned this issue Nov 28, 2022
Merged
100 tasks
@melvin-bot melvin-bot bot added the Overdue label Dec 8, 2022
@Julesssss
Copy link
Contributor Author

Working on the notifications doc currently, returning to this afterwards.

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2022
This was referenced Dec 26, 2022
Closed
Merged
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jan 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 4, 2023

This issue has not been updated in over 15 days. @Julesssss eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot removed the Overdue label Jan 4, 2023
@Julesssss
Copy link
Contributor Author

Holding for now

@melvin-bot melvin-bot bot added the Overdue label Feb 17, 2023
@Julesssss
Copy link
Contributor Author

On hold for now

@melvin-bot melvin-bot bot removed the Overdue label Feb 20, 2023
@Julesssss
Copy link
Contributor Author

Closing as dupe of this older issue that is in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julesssss Julesssss

Labels
Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Julesssss