[HOLD for payment 2022-12-20] Dev: TypeError on dev when workspace settings forms are opened

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Workspace settings.
2. Click on “General settings.”

Alternately,

1. Go to Workspace settings.
2. Click on “Connect bank account.”
3. Click on “Connect manually.”

Expected Result:

Form is opened normally

Actual Result:

Console error on desktop, full page blocking error on iOS (dev) and Android (dev)

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number:
Reproducible in staging?: Need reproduction
Reproducible in production?: Need reproduction
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @dangrous
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670273493519649

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01302e69a126221869
• Upwork Job ID: 1605268377985359872
• Last Price Increase: 2022-12-20

[luacmartins]

I can reproduce this and I'm working on a fix

[melvin-bot]

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix cannot read property inputID of undefined #13348

If no regressions arise, payment will be issued on 2022-12-20. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: Scroll to the right spot when clicking "Fix Errors" #12954
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Scroll to the right spot when clicking "Fix Errors" #12954 (comment)
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A the checklist already has a check for this, we just need to enforce it.
• [] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: N/A this is a console error.

[luacmartins]

We are good to close this one since there's no payment needed!

[mananjadhav]

@luacmartins There will be payment for the C+ review on PR #13348. Can you help with the same?

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

@mananjadhav thanks for bringing that up to my attention. Sorry that I missed that.

@maddylewis the only thing left to do here is pay @mananjadhav for this PR review. Could you help us with that?

[maddylewis]

yes! let me do that now.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01302e69a126221869

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mananjadhav (Internal)

[maddylewis]

okay, @mananjadhav - can you apply to the job and then i will process payment :)

[mananjadhav]

Applied @maddylewis

[maddylewis]

payment sent!

[maddylewis]

ill go ahead and close this out. if there were any issues receiving payment, feel free to reopen and let me know - thanks, @mananjadhav !

[mananjadhav]

Received the payment. Thanks @maddylewis for the help here.