Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Chat - File drop is not detected if payment details are open in chat #13458

Closed
kbecciv opened this issue Dec 9, 2022 · 4 comments
Closed
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Dec 9, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #12056

Action Performed:

  1. Go to https://staging.new.expensify.com/
    and login
  2. Open any chat with IOU
  3. Open IOU details
  4. Drag and drop file to chat

Expected Result:

File drop should be detected

Actual Result:

File drop is not detected if payment details are open in chat

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.37.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

video_09.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 9, 2022

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@francoisl
Copy link
Contributor

I'm not sure if this is actually a bug, I can't think of a use case for dropping a file into the right-hand panel payment details here.
Going to tag @roryabraham for your opinion since you opened #11823.

@parasharrajat
Copy link
Member

This is not a bug and is also unexpected behavior. Opening an RHN window shows a backdrop that indicates that the background is disabled for interactions.

@roryabraham
Copy link
Contributor

I don't think that this is a bug. Agree with @parasharrajat that when the RHP is open then interactions in the chat view should be disabled.

I can't think of a use case for dropping a file into the right-hand panel payment details here

Even if we had a separate use-case for dropping a file into the RHP, that would be:

  • A new feature
  • Another instance of the DragNDrop component

Closing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants