Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account - Message 'Account closed successfully" doesn't appear #13466

Closed
kavimuru opened this issue Dec 9, 2022 · 9 comments
Closed

Account - Message 'Account closed successfully" doesn't appear #13466

kavimuru opened this issue Dec 9, 2022 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Dec 9, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch App and login
  2. Navigate to security > Close account
  3. Enter your default contact method
  4. Tap on "Close account" button

Expected Result:

Account should be close and green dot with the message 'Account closed successfully" appeared.

Actual Result:

Account was closed and only green dot without the message 'Account closed successfully" appeared.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.2.37-0
Reproducible in staging?: y
Reproducible in production?: n
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5855773_close-account-growl.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Dec 9, 2022
@mvtglobally mvtglobally added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 9, 2022

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Gonals Gonals added Improvement Item broken or needs improvement. Engineering Internal Requires API changes or must be handled by Expensify staff labels Dec 9, 2022
@Gonals
Copy link
Contributor

Gonals commented Dec 9, 2022

Grabbing this!

@Gonals
Copy link
Contributor

Gonals commented Dec 9, 2022

Not seeing this in web:
Screenshot 2022-12-09 at 4 37 19 PM

@Gonals
Copy link
Contributor

Gonals commented Dec 9, 2022

Could reproduce it in iOS:
Screenshot 2022-12-09 at 5 00 05 PM

@adelekennedy
Copy link

@Gonals it looks like we won't need external help here - assigning you and unassigning myself!

@chiragsalian
Copy link
Contributor

Not a deploy blocker since the PR was CP'd to staging. I briefly tested on staging ios and it looks like the issue is resolved for me. removing deploy blocker label.

@chiragsalian chiragsalian removed the DeployBlockerCash This issue or pull request should block deployment label Dec 12, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Dec 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 13, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-12-20. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot changed the title Account - Message 'Account closed successfully" doesn't appear [HOLD for payment 2022-12-20] Account - Message 'Account closed successfully" doesn't appear Dec 13, 2022
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 20, 2022
@mallenexpensify mallenexpensify changed the title [HOLD for payment 2022-12-20] Account - Message 'Account closed successfully" doesn't appear Account - Message 'Account closed successfully" doesn't appear Dec 24, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 27, 2022

@Gonals Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Gonals Gonals closed this as completed Dec 28, 2022
@Gonals
Copy link
Contributor

Gonals commented Dec 28, 2022

This was solved internally, so no payments needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants