Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold for payment 2023-01-03] Back Button inside ResendValidationForm isn't displayed as link #13626

Closed
kavimuru opened this issue Dec 15, 2022 · 18 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Dec 15, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to login page
  2. Type email and continue to password page
  3. Click Forget password
  4. Check Back button

Expected Result:

Back button should inherit link style and displayed as link

Actual Result:

Back button does not inherit link style and isn't displayed as link

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.40-3
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-12-14.at.7.31.21.PM.mov
Recording.1104.mp4

Expensify/Expensify Issue URL:
Issue reported by: @fedirjh
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671043886770209

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a3d91135ab0e997d
  • Upwork Job ID: 1612506758739214336
  • Last Price Increase: 2023-01-09
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 15, 2022
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Dec 15, 2022
@luacmartins luacmartins self-assigned this Dec 15, 2022
@luacmartins
Copy link
Contributor

Gonna work on this one!

@kadiealexander
Copy link
Contributor

Sweet! Staying on board so I can issue the reporting bonus to @fedirjh :)

@luacmartins luacmartins mentioned this issue Dec 16, 2022
53 tasks
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Dec 16, 2022
@luacmartins luacmartins added the Internal Requires API changes or must be handled by Expensify staff label Dec 16, 2022
@luacmartins
Copy link
Contributor

PR here

@kadiealexander
Copy link
Contributor

I'm going OOO for a family emergency, if this needs action while I'm away please re-add the bug label to assign someone.

@luacmartins
Copy link
Contributor

@kadiealexander could you please help with the payment for the PR review? This should be a flat $1000 payment to @mollfpr!

@luacmartins
Copy link
Contributor

@kadiealexander I forgot this in my last comment, but we also need to pay the reporting bonus to @fedirjh!

@luacmartins luacmartins changed the title Back Button inside ResendValidationForm isn't displayed as link [Hold for payment 2023-01-03] Back Button inside ResendValidationForm isn't displayed as link Jan 5, 2023
@luacmartins
Copy link
Contributor

Reassigning since Kadie is ooo

@luacmartins luacmartins added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Jan 9, 2023
@melvin-bot melvin-bot bot unlocked this conversation Jan 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 9, 2023

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@luacmartins
Copy link
Contributor

@kevinksullivan could you please help with payment?

Reporting bonus $250 to @fedirjh
PR Review bonus $1000 to @mollfpr

@mallenexpensify mallenexpensify added Internal Requires API changes or must be handled by Expensify staff and removed Internal Requires API changes or must be handled by Expensify staff labels Jan 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 9, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01a3d91135ab0e997d

@melvin-bot
Copy link

melvin-bot bot commented Jan 9, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @rushatgabhane (Internal)

@luacmartins
Copy link
Contributor

Ah yea, I missed the internal label. Thanks for adding it @mallenexpensify!

@mallenexpensify
Copy link
Contributor

Sorry @rushatgabhane , forgot to add @mollfpr before relabeling Internal to get the Upwork job created

Hired @mollfpr and @fedirjh, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01a3d91135ab0e997d

@rushatgabhane
Copy link
Member

no worries :)

@fedirjh
Copy link
Contributor

fedirjh commented Jan 9, 2023

@mallenexpensify Thank you. Offer accepted!!

@mollfpr
Copy link
Contributor

mollfpr commented Jan 9, 2023

@mallenexpensify Accepted!

@kevinksullivan
Copy link
Contributor

Paid @mollfpr and @fedirjh ! Upwork is giving me trouble ending the contract with @fedirjh , if you want to try and take care of that @mallenexpensify ? Otherwise I've noted to give it a try again tomorrow.

@fedirjh
Copy link
Contributor

fedirjh commented Jan 10, 2023

@kevinksullivan I got the payment too . You have to cancel I declined the 2nd offer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

8 participants