[HOLD for payment 2023-02-07] Make app start TTI more accurate

[hannojg]

Action Performed:

• When the app starts we measure the time it takes until the SidebarLinks are rendered, known as "App start TTI".
  This measurement is reported to Grafana. Currently any waiting time due to waiting on network data is included in the TTI. This PR changes that, and will only report the TTI when we render the SidebarLinks with cached data on the first render.
• Currently when reporting to grafana no information about the environment is included, meaning data from staging and production is mixed. This PR also adds env info to the grafana logging.

This is an effort towards: #11997

Expected Result:

• Only report TTI from cached render results (we want to know if we introduced performance regression issues in the code, not whether the API is slow to respond)
• Events reported to grafana include environment information

Actual Result:

/

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Yes they can, this is just for internal performance monitoring.

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.48-2
Reproducible in staging?: N/A
Reproducible in production?: N/A
Email or phone of affected tester (no customers): N/A
Logs: N/A
Notes/Photos/Videos: N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: @hannojg
Slack conversation: None, but this issue #11997

View all open jobs on GitHub

[melvin-bot]

📣 @hannojg! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[hannojg]

I just created this PR for the issue: #13997

[abekkala]

@hannojg did you report this bug in the #expensify-open-source Slack channel? (As you don't directly open issues in this repo)

If so, can you link to that slack conversation please?

[hannojg]

Oh yeah, sorry, I didn't 😅 I am from Margelo and this issue was created as part of Margelos collaboration working week in SF with Expensify.

[AndrewGable]

Confirmed @abekkala - Working with @hannojg on this one. They get paid hourly so no need to worry about upwork.

[melvin-bot]

@AndrewGable, @abekkala, @hannojg Whoops! This issue is 2 days overdue. Let's get this updated quick!

[hannojg]

The PR is still in review @MelvinBot

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.62-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• dev: measure app start TTI more accurately #13997

If no regressions arise, payment will be issued on 2023-02-07. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@AndrewGable] The PR that introduced the bug has been identified. Link to the PR:
• [@AndrewGable] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@AndrewGable] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abekkala] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[abekkala]

@AndrewGable I just want to confirm there is still no action needed from me (BugZero) as payments aren't made via Upwork and I don't need to add/edit a Test Rail?

[AndrewGable]

Confirmed!

[aimane-chnaif]

C+ Payment is pending for internal PR review

[AndrewGable]

@abekkala - Can you please handle? Thanks!

[abekkala]

@AndrewGable LOL so I do need to make a payment via Upwork?
Who is the C+ on this that needs payment? I'm not sure who was considered Margelo and who needs to be paid via Upwork.

[aimane-chnaif]

I am C+ and @hannojg is from Margelo. I am only the one to be paid via upwork

[abekkala]

@aimane-chnaif I've sent you a contract/offer via Upwork.
Once accepted I'll send payment :)

[abekkala]

Payment has been sent, the contract has been completed, and the Upwork job post has been closed.