Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric] iOS - Login - App crashed when try to login. #14089

Closed
1 task
kbecciv opened this issue Jan 6, 2023 · 20 comments
Closed
1 task

[Fabric] iOS - Login - App crashed when try to login. #14089

kbecciv opened this issue Jan 6, 2023 · 20 comments
Assignees
Labels
Engineering Monthly KSv2 NewFeature Something to build that is a new item. Not a priority

Comments

@kbecciv
Copy link

kbecciv commented Jan 6, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch App
  2. Enter email. password
  3. Tap on Sign In

Expected Result:

User able to log in

Actual Result:

App crashed when try to login.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • iOS / native

Version Number: 1.2.49.0 Thu, 5 Jan 2023 18:02 PM

Reproducible in staging?: Yes

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5887387_RPReplay_Final1673042074.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 6, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 6, 2023
@mvtglobally mvtglobally added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 6, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 6, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Jan 6, 2023

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mvtglobally
Copy link

NOTE: this issue is specific to #13767 (comment) CC @WoLewicki

@Luke9389
Copy link
Contributor

Luke9389 commented Jan 6, 2023

@mvtglobally, do you mean this is happening on the branch from that PR?

@mvtglobally
Copy link

@Luke9389, correct! It is NOT a staging app issue

@Luke9389
Copy link
Contributor

Luke9389 commented Jan 6, 2023

Given that the linked PR is a draft, should we delete this issue?

@mvtglobally
Copy link

@Luke9389 Dont delete it pls. There is a special request for this. Tagged you in Slack.

@Luke9389
Copy link
Contributor

Luke9389 commented Jan 6, 2023

Oh ok cool, thanks @mvtglobally!

@mvtglobally
Copy link

@roryabraham @AndrewGable Let us know if any special tagging required for this issue.
This is coming from "Enable Fabric and TurboModules on iOS & Android changes "

@Luke9389
Copy link
Contributor

Luke9389 commented Jan 6, 2023

Just spoke with @mvtglobally 1:1 on slack, and the context for this issue is here: https://expensify.slack.com/archives/C9YU7BX5M/p1672784184899339

Looks like we're performing regression tests for a build on the branch of the linked PR.

For that reason I don't think this is a deploy blocker.

@mvtglobally mvtglobally removed the DeployBlockerCash This issue or pull request should block deployment label Jan 6, 2023
@AndrewGable
Copy link
Contributor

@WoLewicki - Please comment so I can assign you, this is the crash for Fabric.

@Julesssss Julesssss added Daily KSv2 and removed Hourly KSv2 labels Jan 9, 2023
@Expensify Expensify unlocked this conversation Jan 9, 2023
@WoLewicki
Copy link
Contributor

I'll be working on the issue.

@j-piasecki
Copy link
Contributor

I will be working alongside @WoLewicki.

@melvin-bot
Copy link

melvin-bot bot commented Jan 12, 2023

Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Jan 12, 2023
@j-piasecki
Copy link
Contributor

This issue should be fixed by WoLewicki@6e6f84f which updates the commit urbanairship-react-native is installed from to j-piasecki/urbanairship-react-native-module@2d69565.

The issue was coming from the fact that enableUserPushNotifications method was not present on the iOS module of UrbanAirship.

@melvin-bot melvin-bot bot removed the Overdue label Jan 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 19, 2023

@j-piasecki, @WoLewicki Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jan 19, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 6, 2023
@MelvinBot
Copy link

This issue has not been updated in over 14 days. @j-piasecki, @WoLewicki eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2023
@roryabraham
Copy link
Contributor

Looks like all that's left here is to circle back and make sure that this bug is fixed on a new fabric build

@trjExpensify trjExpensify added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 14, 2023
@trjExpensify trjExpensify changed the title iOS - Login - App crashed when try to login. [Fabric] iOS - Login - App crashed when try to login. Feb 14, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Mar 1, 2023
@MelvinBot
Copy link

This issue has not been updated in over 15 days. @j-piasecki, @WoLewicki eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot closed this as completed May 15, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 15, 2023

@j-piasecki, @WoLewicki, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot
Copy link

melvin-bot bot commented Jul 31, 2023

@j-piasecki, @WoLewicki, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Monthly KSv2 NewFeature Something to build that is a new item. Not a priority
Projects
None yet
Development

No branches or pull requests