[HOLD for payment 2023-01-31] IOS - New Room - Unable create a room when using second dash

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #13994

Action Performed:

1. Launch the app
2. Log i with expensifail account
3. Tap on Fub menu
4. Select New Room
5. Use two dashes in the room name field

Expected Result:

Able to use dashes when creating a room

Actual Result:

Unable create a room when using second dash

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• iOS / native

Version Number: 1.2.50.13

Reproducible in staging?: Yes

Reproducible in production?: n/a

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1673192007.1.MP4

RPReplay_Final1673278692.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01eefd02d7b3fd0024
• Upwork Job ID: 1615503215369134080
• Last Price Increase: 2023-01-18

[maddylewis]

interesting! so, if a room can be made with a single hyphen, a room should be made with a double hyphen. therefore, we should build out the capability to create a room with a double hyphen.

this doesn't seem like it would affect the standard end-user experience too much, but the error messaging + capability should be consistent.

i will work on reproducing and then go from there!

[kbecciv]

@maddylewis This is IOS app issue only.

[maddylewis]

oh got it - thanks for clarifying. let me try to reproduce on the app.

[luacmartins]

I can reproduce on iOS. I think the issue is that iOS combines -- into — which is rejected by our validation. I can work on a fix.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01eefd02d7b3fd0024

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[luacmartins]

PR up

[luacmartins]

PR in prod!

[mollfpr]

@maddylewis Could you help issue the payment here? Thanks!

[maddylewis]

@mollfpr - will you apply to the job so that i can issue payment? https://www.upwork.com/jobs/~01eefd02d7b3fd0024

thanks!

[mollfpr]

@maddylewis applied thanks!

[maddylewis]

alrighty, i think we're all paid up on this one.

[mollfpr]

@maddylewis offer accepted!

[luacmartins]

@maddylewis have we handled all payments for this issue? Can we close this?

[dylanexpensify]

Payment sent!!