Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Page - Incorrect error message for entering 9 fake numbers for SSN #14251

Closed
6 tasks
kbecciv opened this issue Jan 12, 2023 · 6 comments
Closed
6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jan 12, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #13170
Attached another video with Send Money flow as in the PR and issue is reproducible.

Action Performed:

  1. Go to NewDot and login with expensifail account
  2. Go to https://staging.new.expensify.com/enable-payments
  3. Fill up the correct information in all the fields in Additional info page with SSN 1234
  4. Close the form
  5. Visit again https://staging.new.expensify.com/enable-payments
  6. Enter 1234 in SSN field and click "Save & continue , then prompted to set all 9 digits of the SSN
  7. Enter 123456789 and click save & continue

Expected Result:

Correct error message is showing for entering 9 fake numbers for SSN

Actual Result:

Incorrect error message for entering 9 fake numbers for SSN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.53.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Uploading Bug5893695_13170.mp4…

Recording.1271.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 12, 2023

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 12, 2023
@kavimuru
Copy link

@lschurr Issue occurs with send money flow too

Recording.1271.mp4

@luacmartins luacmartins self-assigned this Jan 12, 2023
@luacmartins
Copy link
Contributor

luacmartins commented Jan 12, 2023

@kavimuru what is the correct error message? From the videos, it seems like this is the expected behavior. The user has a valid 4 digit SSN, and we display the API error above the submit button asking them to enter the full 9 digits SSN instead

@joelbettner
Copy link
Contributor

This is the desired behavior for the SSN.

The user entered 4 numbers of the SSN. The back end returns an error that we need the entire 9 digits of the SSN for this particular user. We display that message above the "Submit" button. We do not display an error in the SSN field unless the user attempts to submit again without the 9 digits.

Closing this issue.

@joelbettner
Copy link
Contributor

For more context, see step 10 of the QA/tests here: #13170

@kavimuru
Copy link

@joelbettner Step 13 and Step 14 error messages are different

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants