Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-01-30] Remove at-mentions in deploy comments #14404

Closed
roryabraham opened this issue Jan 18, 2023 · 2 comments
Closed

[HOLD for payment 2023-01-30] Remove at-mentions in deploy comments #14404

roryabraham opened this issue Jan 18, 2023 · 2 comments
Assignees
@roryabraham
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Problem

When NewDot deploys happen, the deploy comments tag the person who deployed the PR – whether that's the current deployer or the person that merged the PR. For deployers, this creates a bunch of unnecessary noise in their email inboxes and wastes time.

Solution

Adjust the deploy comment so that it doesn't actually tag the person, but just mentions them with a link to their GitHub profile.

Before

@roryabraham

After

https://github.com/roryabraham

View all open jobs on GitHub
@roryabraham roryabraham added Engineering Daily KSv2 Improvement Item broken or needs improvement. labels Jan 18, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 18, 2023
@roryabraham roryabraham mentioned this issue Jan 18, 2023
Closed
@roryabraham roryabraham self-assigned this Jan 19, 2023
@roryabraham roryabraham changed the title [HOLD] Remove at-mentions in deploy comments Remove at-mentions in deploy comments Jan 19, 2023
@roryabraham
Copy link
Contributor Author

This is suuuper low-hanging fruit and it's mostly a QOL improvement for me and other deployers, so I'm just going to do it really quick

@roryabraham roryabraham mentioned this issue Jan 19, 2023
Merged
54 tasks
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jan 19, 2023
@roryabraham roryabraham added Weekly KSv2 Monthly KSv2 and removed Daily KSv2 Weekly KSv2 labels Jan 19, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jan 23, 2023
@melvin-bot melvin-bot bot changed the title Remove at-mentions in deploy comments [HOLD for payment 2023-01-30] Remove at-mentions in deploy comments Jan 23, 2023
@roryabraham
Copy link
Contributor Author

This was fixed in #14407, no payment due

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roryabraham roryabraham

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roryabraham