Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-02-18] Storybook is broken locally #14905

Closed
1 of 6 tasks
marcaaron opened this issue Feb 7, 2023 · 6 comments
Closed
1 of 6 tasks

[HOLD for payment 2023-02-18] Storybook is broken locally #14905

marcaaron opened this issue Feb 7, 2023 · 6 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Feb 7, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Run storybook locally

Expected Result:

It works

Actual Result:

Get this error:

ModuleBuildError: Module build failed (from ./node_modules/css-loader/dist/cjs.js):
Error: Can't resolve '/fonts/ExpensifyNeue-Regular.woff2' in '/Users/marcglasser/Expensidev/App/assets/css'
    at finishWithoutResolve (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/Resolver.js:309:18)
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/Resolver.js:386:15
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/Resolver.js:435:5
    at eval (eval at create (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/Resolver.js:435:5
    at eval (eval at create (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:27:1)
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:87:43
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/Resolver.js:435:5
    at eval (eval at create (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/forEachBail.js:16:12
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/AliasPlugin.js:125:14
    at next (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/forEachBail.js:14:3)
    at forEachBail (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/forEachBail.js:24:9)
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/AliasPlugin.js:51:5
    at _next0 (eval at create (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:8:1)
    at eval (eval at create (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:30:1)
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/Resolver.js:435:5
    at eval (eval at create (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/Resolver.js:435:5
    at eval (eval at create (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/Resolver.js:435:5
    at eval (eval at create (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/Resolver.js:435:5
    at eval (eval at create (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/Resolver.js:435:5
    at eval (eval at create (/Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)
    at /Users/marcglasser/Expensidev/App/node_modules/enhanced-resolve/lib/DirectoryExistsPlugin.js:41:15
    at processTicksAndRejections (node:internal/process/task_queues:82:21)
    at processResult (/Users/marcglasser/Expensidev/App/node_modules/webpack/lib/NormalModule.js:758:19)
    at /Users/marcglasser/Expensidev/App/node_modules/webpack/lib/NormalModule.js:860:5
    at /Users/marcglasser/Expensidev/App/node_modules/webpack/node_modules/loader-runner/lib/LoaderRunner.js:400:11
    at /Users/marcglasser/Expensidev/App/node_modules/webpack/node_modules/loader-runner/lib/LoaderRunner.js:252:18
    at context.callback (/Users/marcglasser/Expensidev/App/node_modules/webpack/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at Object.loader (/Users/marcglasser/Expensidev/App/node_modules/css-loader/dist/index.js:155:5)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

WARN Broken build, fix the error above.
WARN You may need to refresh the browser.

Workaround:

Dev only issue

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01809793b2aad8dcd7
  • Upwork Job ID: 1622978214386040832
  • Last Price Increase: 2023-02-07
@marcaaron marcaaron added the Internal Requires API changes or must be handled by Expensify staff label Feb 7, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 7, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01809793b2aad8dcd7

@MelvinBot
Copy link

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

@marcaaron
Copy link
Contributor Author

This is an easy one so we don't need a C+ review. Thanks.

@marcaaron marcaaron mentioned this issue Feb 7, 2023
54 tasks
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Feb 7, 2023
@melvin-bot melvin-bot bot unlocked this conversation Feb 7, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Feb 10, 2023
@melvin-bot melvin-bot bot changed the title Storybook is broken locally [HOLD for payment 2023-02-18] Storybook is broken locally Feb 11, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 11, 2023
@MelvinBot
Copy link

Reviewing label has been removed, please complete the "BugZero Checklist".

@MelvinBot
Copy link

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-02-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Feb 17, 2023
@marcaaron
Copy link
Contributor Author

No payment here this was all done internally from start to finish.

@melvin-bot melvin-bot bot removed the Overdue label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

3 participants