[HOLD for payment 2023-03-01] [$1000] Remove PersonalDetails.setPersonalDetails

[puneetlath]

This function uses the deprecated API and is no longer needed as @fedirjh pointed out here. Let's remove it.

@fedirjh would you want to take this?

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012fcfc8598f70c4dd
• Upwork Job ID: 1623455820462211072
• Last Price Increase: 2023-02-08

[MelvinBot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[fedirjh]

@puneetlath Thank you , I will take it.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~012fcfc8598f70c4dd

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[MelvinBot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

📣 @fedirjh You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[fedirjh]

@sobitneupane PR Ready for Review #14979

[MelvinBot]

@puneetlath, @sobitneupane, @fedirjh Whoops! This issue is 2 days overdue. Let's get this updated quick!

[puneetlath]

We're chatting in the PR about some issues that we've realized this change might cause.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.75-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Refactor] Remove deprecated PersonalDetails.setPersonalDetails #14979

If no regressions arise, payment will be issued on 2023-03-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter n/a
• Contributor that fixed the issue @fedirjh
• Contributor+ that helped on the issue and/or PR @sobitneupane

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[puneetlath]

This wasn't a bug, rather was a refactor, so BZ checklist isn't applicable here.

[puneetlath]

All paid. Thanks everyone!