[HOLD for payment 2023-03-17] [HOLD #14549] The country field is set to null while selecting US addresses, only in Spanish language preference

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to Settings and change to the Spanish language
2. Go to Profile
3. Go to Personal information
4. Go to address
5. Try to first change the country to a different country besides the United states .
6. Next, change the location address to any US address. (like texas /arizona ) and Notice that the Country field is set to null and throws error while saving.

Expected Result:

Country should be updated while selecting US address even in spanish

Actual Result:

Country field is set to null and throws error while saving in spanish.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.68-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-02-09.at.3.58.31.PM.mov

Recording.1486.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ashimsharma10
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675938847425899

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[abekkala]

@Beamanator Would the fix for #14549 resolve this one as well?
Or should I continue on with this one as it's own Upwork job?

[abekkala]

I'm going to verify this needs it's own job first

[Beamanator]

Ooh good point @abekkala - that's verryyyy possible!

[Beamanator]

I do think it makes sense to hold this one for a bit - and I'll mention that we want to make this "fix" / "feature" via the fix for that other issue 👍

[abekkala]

Sounds good @Beamanator

[Beamanator]

Making weekly while this is on hold

[abekkala]

Still on hold for the other

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.81-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CountryPicker & StatePicker] Internationalization based on ISO codes #15507

If no regressions arise, payment will be issued on 2023-03-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Beamanator] The PR that introduced the bug has been identified. Link to the PR:
• [@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abekkala] Determine if we should create a regression test for the bug.
• [@Beamanator] If we decide to create a regression test for the bug, please propose the regression test steps to the appropriate location to ensure the same bug will not reach production again.
• [@abekkala] Review the proposed regression test steps and location.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[abekkala]

@Beamanator - I'm confused by the latest Melvin posts lol
Was this issue fixed by the other GH or should we move forward fro this one to have it's own job?

[Beamanator]

Aah rightttt I thinkkk we can just check that this issue no longer exists in production, then we can probably close it out since payment & other BZ tasks are happening in #14549

[ashimsharma10]

@Beamanator
I'm the external reporter and have not paid for this. I'm a new member and don't know where to ask for it.

[MelvinBot]

📣 @ashimsharma10! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[abekkala]

Do we pay out for a report for something that was being fixed via a different GH?
@Beamanator

[abekkala]

@ashimsharma10 Payment for this is not made as the fix was in place for this via another GH - #14549
Which was already in place before this one.

[Beamanator]

I agree with what you're saying @abekkala 👍