Payments - Deleted Payment method is present after go back online

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #14869

Action Performed:

1. Log in with the same in both devices ( Web and mWeb)
2. Go to Setting - Payments in Web
3. Add PayPal payment
4. Go to mWeb and verify if you see PayPal payment method
5. Click on a payment method, so 'Delete' modal comes up.
6. Now the delete the payment method from another device ( Web)
7. Back online on mWeb

Expected Result:

Deleted Payment method is not present after go back online

Actual Result:

Deleted Payment method is present after go back online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.69.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5932416_14869_Web_offline.mp4

14869.mWeb.Offline.mp4

14869.IOS.Offine.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause- Internal Team

Slack conversation:

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[joekaufmanexpensify]

Will reproduce today.

[joekaufmanexpensify]

@kbecciv I reviewed the reproduction steps, and videos you shared, but I'm not quite sure exactly what the bug is here.

The reproduction steps mention deleting the paypal payment method, but I don't see that it's deleted in any of the three videos. The results step also mention some offline actions, and these are shown in the videos, but they're not really mentioned much in the reproduction steps.

Could you take another look at this and make sure the reproduction steps cover exactly what's outlined in the videos, and that it's clear in the results section where it's expected that the paypal payment method is deleted vs not?

[joekaufmanexpensify]

I'm going to close for now as I'm not quite sure what the reproduction steps are here/what the bug is, but feel free to re-open once this is updated and happy to work on reproducing this!

[kbecciv]

@joekaufmanexpensify Please follow this Offline test steps from PR #14869

[joekaufmanexpensify]

Got it, I'll take a look!

[joekaufmanexpensify]

@kbecciv The steps you outlined in your most recent comment are different/seem like a different bug than those in the OP of the issue, no?

I'm not sure if I should be testing this with paypal specifically (as listed in OP of the issue), or if any payment method is fine?

Also, is the bug that the delete/set default payment method modal is not being dismissed after coming online on device 1, after the payment method is deleted on device 2 or that the payment method itself is not being deleted on device 1, or both?

[joekaufmanexpensify]

@kbecciv I'm going to close this for now, as it's still not clear to me what specifically I should be testing here. The steps linked from the other PR seem like a different bug than those in the OP of this issue. It also looks like we've captured the modal not being dismissed in this bug report.

Feel free to re-open if there is still a separate bug to reproduce here. However, if there is, could you please update the reproduction steps at the top of the issue so it's clear exactly what steps should be taken to reproduce the bug, and make sure the videos showing the bug match the reproduction steps? Thanks!