Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-02-17 #15260

Closed
17 tasks done
OSBotify opened this issue Feb 17, 2023 · 4 comments
Closed
17 tasks done

Deploy Checklist: New Expensify 2023-02-17 #15260

OSBotify opened this issue Feb 17, 2023 · 4 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Feb 17, 2023

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Feb 17, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 17, 2023
@mvtglobally
Copy link

mvtglobally commented Feb 20, 2023

Regression is completed.

We are having issues with few PRs and will need your help
PR #14579 Team is not sure how to run this on the multiple devices. Steps are more Dev specific
#15179 is failing #15273 #15272 #15179 & is blocked on the Native apps due to old KI, rest are pass.

#15201 is still repro on mWeb/Safari
#15180 is blocked on the Native apps due to old KI, rest are pass.
#15167 is failing #15264. repro in PROD. checking off

@chiragsalian
Copy link
Contributor

#14579 doesn't seem very dev specific. Not sure which part of the test requires you to run on multiple devices. It sounds more like you need to run on one platform and then check the console logs. For mobile, you've to check the NVP status on the console on web. Doesn't sound too tricky but if there is some part that tricky can you let me know which section and number it is?

I'll check off #15179 and #15180 since we can't much about native apps old KI.

#15201 - hmm I wasn't able to reproduce this on iOS safari. The scroll is a bit weird but I don't see any flashing when switching between edit inputs. I'll check this off. Since no reason for it to block deploy and if the issue persists we can update it later with a follow up.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Feb 20, 2023
@roryabraham
Copy link
Contributor

@chiragsalian and I tested #14579, checking it off

@chiragsalian
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants