[Add Regression Test] DEV: @expensify.sms shown on sign up page when entering phone number

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open NewDot
2. Enter any phone number which does not have account

Expected Result:

Page should not show @expensify.sms

Actual Result:

Page show with expensify.sms

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: dev on main
Reproducible in staging?: Only occurs in dev on main
Reproducible in production?: Only occurs in dev on main
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676666826794699

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015abf53198e3aa940
• Upwork Job ID: 1628354733573238784
• Last Price Increase: 2023-02-22

[MelvinBot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Julesssss]

Taking this. There are a few usages of the isSMSLogin ? toLocalPhone | Str.removeSMSDomain function that can be refactored into a helper funciton.

[Julesssss]

My guess is that this wasn't reproducible on staging because an old phone number was used. We show a different message depending on whether you are a new or returning user (and this also requires you are on the passwordless beta)

[twisterdotcom]

Should I label this internal Jules?

[Julesssss]

Yeah, I'll fix it today 👍

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~015abf53198e3aa940

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[Julesssss]

PR in review: #15351

[MelvinBot]

@twisterdotcom, @Julesssss, @mollfpr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[twisterdotcom]

How is it overdue? Get out of here! Just waiting for it to deploy right?

[Julesssss]

Yeah 👍

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.77-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix miss-matched SMS email suffix on sign in page #15351

If no regressions arise, payment will be issued on 2023-03-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr / @Julesssss] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr / @Julesssss] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr / @Julesssss] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Propose regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Julesssss]

Couldn't locate the regression, but here's a test we can create:

Confirm SMS login is aligned and has no suffix

• Sign out
• Sign in using an SMS number (for example, +17474744747)
• The welcome message should not include the @expensify.sms suffix
• Both the welcome message and the 'Not XYZ, go back' messages should show the same login

[Julesssss]

@twisterdotcom please feel free to make the testcase when you have a chance.

[twisterdotcom]

This is paid. I'm going to make it weekly.

[mollfpr]

@twisterdotcom May I confirm if I already accept the offer? I forgot if I already get paid or not 😅

[mollfpr]

Bump @twisterdotcom to help clarify the above comment. Thank you!

[twisterdotcom]

Hmm, I don't think you did no. The Upwork job I closed: https://www.upwork.com/jobs/~015abf53198e3aa940

I am just going to send over an offer.

[twisterdotcom]

https://www.upwork.com/nx/wm/pre-hire/c/8577561/offer/23873369 - @mollfpr accept this please

[twisterdotcom]

The [HOLD is confusing that this is on me in my K2. Removing it.

[mollfpr]

@twisterdotcom Accepted thank you!