[HOLD for payment 2023-03-17] Fix broken logic in isIOUOwnedByCurrentUser

[luacmartins]

Problem

The logic in isIOUOwnedByCurrentUser is broken, since it always returns false as currentUserLogin is an object containing user login information and not the user email.

Additionally, this line always returns true for !report.isIOUReportOwner since isIOUReportOwner is not a property of the report object.

Why is this important

Broken logic results in unexpected behavior

Solution

Fix it

[MelvinBot]

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

PR is in review!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.81-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix isIOUOwnedByCurrentUser #15339

If no regressions arise, payment will be issued on 2023-03-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[luacmartins]

This issue was reported, worked on and reviewed internally. So no payments are due. Closing it!