Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD on #14676] [$500] IOS - Chat - The emoji is cut off from the top if it is written in the format # :emoji: #15734

Open
1 of 6 tasks
kbecciv opened this issue Mar 8, 2023 · 47 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Mar 8, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Login with any account
  3. Go to any chat
  4. Sent the message as # :emoji:

Expected Result:

Emoji are not cropped

Actual Result:

The emoji is cut off from the top if it is written in the format # :emoji:

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.80.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5967986_RPReplay_Final1678226669.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0149fd0513a33e8e3a
  • Upwork Job ID: 1637961531085971456
  • Last Price Increase: 2024-02-26
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 8, 2023
@MelvinBot
Copy link

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 8, 2023
@MelvinBot
Copy link

MelvinBot commented Mar 8, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Mar 10, 2023
@twisterdotcom
Copy link
Contributor

I have a feeling this is going to be fixed by the same thing as #14445, right @kbecciv?

Should we HOLD this for the same PR: #15611

@melvin-bot melvin-bot bot removed the Overdue label Mar 12, 2023
@twisterdotcom twisterdotcom changed the title IOS - Chat - The emoji is cut off from the top if it is written in the format # :emoji: [HOLD on #15611] IOS - Chat - The emoji is cut off from the top if it is written in the format # :emoji: Mar 12, 2023
@kbecciv
Copy link
Author

kbecciv commented Mar 13, 2023

@twisterdotcom I think this is completely different issue.

@melvin-bot melvin-bot bot added the Overdue label Mar 14, 2023
@MelvinBot
Copy link

@twisterdotcom Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MelvinBot
Copy link

@twisterdotcom Huh... This is 4 days overdue. Who can take care of this?

@twisterdotcom
Copy link
Contributor

Okay, cool. I can repro. It's weird we have them in headers but whatever. Let's allow it!

@melvin-bot melvin-bot bot removed the Overdue label Mar 20, 2023
@twisterdotcom twisterdotcom changed the title [HOLD on #15611] IOS - Chat - The emoji is cut off from the top if it is written in the format # :emoji: IOS - Chat - The emoji is cut off from the top if it is written in the format # :emoji: Mar 20, 2023
@twisterdotcom twisterdotcom added the External Added to denote the issue can be worked on by a contributor label Mar 20, 2023
@melvin-bot melvin-bot bot unlocked this conversation Mar 20, 2023
@melvin-bot melvin-bot bot changed the title IOS - Chat - The emoji is cut off from the top if it is written in the format # :emoji: [$1000] IOS - Chat - The emoji is cut off from the top if it is written in the format # :emoji: Mar 20, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0149fd0513a33e8e3a

@MelvinBot
Copy link

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 20, 2023
@MelvinBot
Copy link

Triggered auto assignment to @youssef-lr (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@Sulman431
Copy link

Sulman431 commented Mar 21, 2023

This issue does not seems to be due to type of emoji,
rather it seems your messageCellHeight is being decided on the basis of content in the message.

When you send an emoji in the form of text, It calculates cell height on the basis of text font size lets say it is 14 pixel.
It returns the cell height 14 plus some threshold +5 or whatever number used, due to confusion in content the cell heigh computing function confuses it.

Just to try it make the height threshold number a little higher an check if it is still cutting the emoji.

Do let me know if you have confusion in understanding what I am saying...Contributor details

Your Expensify account email: sulmanmlaik431@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/sulman012?viewMode=1&s=996364627857502209

@MelvinBot
Copy link

📣 @Sulman431! 📣

Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Screen Shot 2022-11-16 at 4 42 54 PM

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@ShogunFire
Copy link
Contributor

It looks like the emoji is bold, there is another issue like this where they said emojis shouldn't be affected by markdowns, they have a PR incoming I think : #14676

@twisterdotcom
Copy link
Contributor

Weird, I did upload the wrong one. I'll hide that, but I agree, this is still an issue. I'll hold on that.

@twisterdotcom twisterdotcom changed the title [$500] IOS - Chat - The emoji is cut off from the top if it is written in the format # :emoji: [HOLD on #14676] [$500] IOS - Chat - The emoji is cut off from the top if it is written in the format # :emoji: Mar 4, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 12, 2024
@youssef-lr
Copy link
Contributor

Still held.

@twisterdotcom
Copy link
Contributor

Still held

@youssef-lr
Copy link
Contributor

Same ^

@melvin-bot melvin-bot bot removed the Overdue label May 21, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 24, 2024
@twisterdotcom
Copy link
Contributor

Same

@melvin-bot melvin-bot bot removed the Overdue label Jun 24, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 25, 2024
@twisterdotcom
Copy link
Contributor

Same

@melvin-bot melvin-bot bot removed the Overdue label Jul 26, 2024
@melvin-bot melvin-bot bot added the Overdue label Aug 26, 2024
@youssef-lr
Copy link
Contributor

Still held.

@melvin-bot melvin-bot bot removed the Overdue label Aug 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 30, 2024
@twisterdotcom
Copy link
Contributor

Still held?

@melvin-bot melvin-bot bot removed the Overdue label Sep 30, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2024
@twisterdotcom
Copy link
Contributor

#14676 is still open. Held on that.

@melvin-bot melvin-bot bot removed the Overdue label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Monthly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants