Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspaces - Cursor overlaps with the currency abbrev (inside the Rate input field) #15789

Closed
6 tasks done
kbecciv opened this issue Mar 9, 2023 · 21 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Mar 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the App
  2. Login with any account
  3. Go to Settings -> Workspaces -> Open any WS -> Reimburse expenses
  4. Delete the value in the window Rate
  5. Pay attention to the cursor in the window Rate

Expected Result:

Cursor NOT overlaps with the currency icon

Actual Result:

Cursor overlaps with the currency icon

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.81.0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 9, 2023
@MelvinBot
Copy link

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 9, 2023
@MelvinBot
Copy link

MelvinBot commented Mar 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Mar 13, 2023
@MelvinBot
Copy link

@michaelhaxhiu Huh... This is 4 days overdue. Who can take care of this?

@michaelhaxhiu
Copy link
Contributor

@kbecciv can you provide the exact screenshot? I tried to reproduce but not seeing a problem on my end following your steps:

image

@melvin-bot melvin-bot bot removed the Overdue label Mar 16, 2023
@michaelhaxhiu
Copy link
Contributor

Can you handle that step of ensuring the screenshot or video under Notes/Photos/Videos: Any additional supporting documentation is provided?

@kbecciv
Copy link
Author

kbecciv commented Mar 16, 2023

@michaelhaxhiu Re-added a new screenshot.

@michaelhaxhiu
Copy link
Contributor

image

Hm so what's the bug? The cursor line?

@kavimuru
Copy link

@michaelhaxhiu Cursor is touching the currency place holder.

@MelvinBot
Copy link

@kbecciv Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Mar 21, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@MelvinBot
Copy link

@kbecciv this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@MelvinBot
Copy link

@kbecciv 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@MelvinBot
Copy link

@kbecciv 10 days overdue. Is anyone even seeing these? Hello?

@MelvinBot
Copy link

@kbecciv 12 days overdue. Walking. Toward. The. Light...

@MelvinBot
Copy link

@kbecciv this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@MelvinBot
Copy link

@kbecciv 12 days overdue. Walking. Toward. The. Light...

@michaelhaxhiu michaelhaxhiu self-assigned this Mar 30, 2023
@michaelhaxhiu
Copy link
Contributor

michaelhaxhiu commented Mar 30, 2023

Chatted 1:1 with Kavi today, and I understand now!!

The screenshot was failing to upload initially

The | cursor is on top of the first letter of the currency abbreviation. I see!

@melvin-bot melvin-bot bot removed the Overdue label Mar 30, 2023
@jayeshmangwani
Copy link
Contributor

@michaelhaxhiu We had a similar issue in the past, and at the end of a long discussion and brief findings, we concluded that the issue was not worth solving
cc: @shawnborton

@michaelhaxhiu
Copy link
Contributor

Thanks @jayeshmangwani, that's quite helpful precedent to refer to!

I am torn personally and had a hard time even understanding/seeing the bug in the first place (given its subtlety).

@michaelhaxhiu michaelhaxhiu changed the title Workspaces - Cursor overlaps with the currency icon Workspaces - Cursor overlaps with the currency abbrev (inside the Rate input field) Mar 30, 2023
@shawnborton
Copy link
Contributor

I think we can just close this.

@michaelhaxhiu
Copy link
Contributor

Posted in slack and discussed. Like shawn mentioned, we are going to close this GH because it's a feature :)

@MelvinBot
Copy link

@michaelhaxhiu Be sure to fill out the Contact List!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

6 participants