[HOLD for payment 2023-04-07] [$1000] Workspace - Default currency field doesn't look good if the field is disabled

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with expensifail account which has Control policy ( you can use appluasetester+0901abb@applause.expensifail.com)
3. Go to Settings - Workspace - Tap on Avatar
4. Check Workspace Settings

Expected Result:

Default currency field looks good if the field is disabled.

Actual Result:

Default currency field doesn't look good if the field is disabled

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.82.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0113fa5fec5ef1c2ae
• Upwork Job ID: 1635970689731641344
• Last Price Increase: 2023-03-22

[MelvinBot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[twisterdotcom]

@kbecciv what do you mean by "looks good" here?

[kbecciv]

@twisterdotcom User should not seen greenish color under Default currency field, or it should completely cover the surface without gap.

[twisterdotcom]

Okay here it is. It can only be disabled when the workspace as a VBA added:

Not sure what @Expensify/design would prefer here. Making External

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0113fa5fec5ef1c2ae

[MelvinBot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[MelvinBot]

Triggered auto assignment to @cristipaval (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The disabled state picker looks ugly.

What is the root cause of that problem?

As explained above, we're setting a highlight colour on disabled picker and adding a border as well.

What changes do you think we should make in order to solve the problem?

As pointed by @kbecciv, we can either remove the border by adding the following here:

this.props.isDisabled && {borderBottomWidth: 0},

Or remove the background colour altogether by removing this line. We can keep the border or remove it depending on the requirement.

If there is any other change, @shawnborton can mention it.

Note: These changes can be applied to Native platforms only if we don't want these on desktop and web. But the idea will remain the same.

Result
Without border:

Without border and highlight colour:

With border and without highlight colour:

What alternative solutions did you explore? (Optional)

None

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent background color for Disabled RNPickerSelect

What is the root cause of that problem?

For disabled RNPickerSelect, we are applying the green bg to parent View here which makes the look inconsistent.

What changes do you think we should make in order to solve the problem?

Remove the disabled style from the RNPickerSelect's parent View from here which will help to remove the incorrect BG.

App/src/components/Picker/Picker.js

Line 180 in eedd92a

this.props.isDisabled && styles.inputDisabled,

The border is valid and consistent with other inputs.

[cristipaval]

I think this one is delayed due to ECX.

[cristipaval]

Melvin? Are you ok? Just remove it, don't add it again.

[shawnborton]

If the field can't be edited, we should just use our standard way of display this kind of input content in a "read-only" fashion. For example, how we display things in a user profile:

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.92-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix-15877: add disabled state styles to Picker #16449

If no regressions arise, payment will be issued on 2023-04-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @cristipaval] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@JmillsExpensify / @twisterdotcom] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify / @twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MelvinBot]

@JmillsExpensify, @twisterdotcom, @cristipaval, @rushatgabhane, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@JmillsExpensify, @twisterdotcom, @cristipaval, @rushatgabhane, @allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[cristipaval]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @cristipaval] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @cristipaval] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @cristipaval] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

@rushatgabhane Could you have a look at these?

[rushatgabhane]

@cristipaval this is a feature request to add a disabled style and a hint to Picker component.

I believe BZ checklist isn't applicable here.

[cristipaval]

Thanks for checking @rushatgabhane ! We're good then.

[MelvinBot]

@JmillsExpensify, @twisterdotcom, @cristipaval, @rushatgabhane, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

[cristipaval]

I think this is on you, @twisterdotcom. Payments are the only leftovers.

[twisterdotcom]

Sent invites for payment to you @rushatgabhane and @allroundexperts.

[twisterdotcom]

@rushatgabhane and @JmillsExpensify Can this regress now, it's a feature. I suppose we could ensure that the currency field can't be edited once a VBA is added, and it would be fairly easy to add.

[JmillsExpensify]

I thought we agreed for these small cosmetic things that we wouldn't create a regression?

[rushatgabhane]

I suppose we could ensure that the currency field can't be edited once a VBA is added, and it would be fairly easy to add.

im pretty sure we already have a regression test for this.
because i have seen issues that were created whenever it broke.

@kbecciv maybe can confirm if there's a regression test for "currency field shouldn't be editable if a workspace has VBA linked"

[JmillsExpensify]

I'll check quickly and see if I can find it.

[JmillsExpensify]

I didn't see it in the Workspace folder of tests, so we'll wait for Applause to confirm.

[rushatgabhane]

Okay then we should definitely add regression steps
how about?

1. Login
2. Create a new workplace (if you don't have one already)
3. Connect a bank account to the workspace (if you don't have one already)
4. Go to Workspace Settings
5. Verify that the default currency can't be edited

[twisterdotcom]

Nice, cool. https://github.com/Expensify/Expensify/issues/277004