[HOLD for payment 2023-04-12] Web- Split Bill - App is crash when 'Split Bill'/Request

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in to a HIGH TRAFFIC (Expensifail) account
2. Click on the green plus button (FAB)
3. Click in Split Bill
4. Enter an amount in the big number pad page
5. Click on the next button

Expected Result:

App is not crash when 'Split Bill'

Actual Result:

App is crash when 'Split Bill'

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.83.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers): applausetester+fachat1@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5976106_crash.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Issue is reproduced occasionally with two testers, credential used: applausetester+fachat1@applause.expensifail.com and applausetester+3012@applause.expensifail.com

[jasperhuangg]

I can't reproduce this with my testing accounts. It seems that it's caused by a participants array sent back with the report that we're accessing here containing holes. Some of the logins in the array are undefined, causing the exception to be thrown.

[neil-marcellini]

I can't reproduce this with a high traffic account on dev or staging so I don't think it's a deploy blocker because it seems to be specific to these accounts.

[MelvinBot]

@neil-marcellini Whoops! This issue is 2 days overdue. Let's get this updated quick!

[neil-marcellini]

Sorry for the delay, busy at ECX. @kbecciv would you please provide me with login information for applausetester+fachat1@applause.expensifail.com so I can see what the problem is? I'm pretty sure this is a backend problem which is specific to that account, and I would love to see what the API is returning so I can trace it back to the root problem.

[neil-marcellini]

I'll try to investigate this a bit more, using supportal, later today or tomorrow.

[kbecciv]

@neil-marcellini Expensifail accounts is Passwoldless.

[neil-marcellini]

Oh right. I don't have access to the sign in code however. Maybe I'll get in touch with you on Slack when I'm ready to test it and you can send me the code.

[neil-marcellini]

As shown by the console trace, somehow the login value here is undefined

App/src/libs/OptionsListUtils.js

Line 111 in 268482d

displayName: Str.removeSMSDomain(login),

[neil-marcellini]

I've been focusing on writing the distance requests doc. I'll try to debug this for a little bit today.

[isagoico]

Oh right. I don't have access to the sign in code however. Maybe I'll get in touch with you on Slack when I'm ready to test it and you can send me the code.

@neil-marcellini Not sure if the account access has been resolved already. You can reach out to me @mvtglobally or @kavimuru via Slack if you need assistance accessing applause.expensifail accounts as Kat doesn't Slack access at the moment.

[neil-marcellini]

I think it's going to be extremely hard to track down where the problem came from, because there's an undefined participant on some report that's shared with your account. Therefore I made a front end change to prevent this problem from causing a crash. We'll run the QA steps on the account in the description to make sure it actually fixes the problem.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.94-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Prevent a bill split crash when a report has an undefined participant #16816

If no regressions arise, payment will be issued on 2023-04-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[neil-marcellini]

Oh, I could have closed this a while ago. No contributors were involved. All done!