Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-03-15 #15983

Closed
8 tasks done
OSBotify opened this issue Mar 15, 2023 · 7 comments
Closed
8 tasks done

Deploy Checklist: New Expensify 2023-03-15 #15983

OSBotify opened this issue Mar 15, 2023 · 7 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Mar 15, 2023

Release Version: 1.2.85-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 15, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Mar 15, 2023
@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.85-1 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.85-1 has been deployed to staging 🎉

@mvtglobally
Copy link

@Julesssss Regression is completed

#15994 is blocked on IOS #15158. Rest is pass

@Julesssss Julesssss self-assigned this Mar 16, 2023
@Julesssss
Copy link
Contributor

#15994 is blocked on IOS #15158. Rest is pass

Thanks. Given that the original issue was only reported for Android, and that we are unable to verify iOS due to the unresolved issue I'm going to check it off 👍

@Julesssss
Copy link
Contributor

App timings are consistent

@Julesssss
Copy link
Contributor

We have one crash on Android which has reappeared. But this was isolated to a single user, and it doesn't seem possible that the merged changes are in any way related to PDF rendering. Ignoring this as a coincidence.

nothing to report on iOS

@Julesssss
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants