[HOLD for payment 2023-05-25] [$2000] Android - App adds additional letters after selecting a suggested emoji and pressing Enter (gboard)

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the Android app
2. Open any chat
3. Type colon and 2 letters to get emoji suggestions (eg: ':he',':jo',':bl')
4. Select any one suggested emoji and press enter

Expected Result:

You should go to the next line (this is typical "Enter" behaviour)

Actual Result:

App goes to next line but adds previously typed 2 letters after the emoji (see video below)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.88-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

emoji.adding.2.letters.in.end.issue.mp4

Record_2023-03-19-11-38-48_4f9154176b47c00da84e32064abf1c48.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679074253884739

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010623c6559be6640a
• Upwork Job ID: 1638426418352893952
• Last Price Increase: 2023-05-08

[MelvinBot]

Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[davidcardoza]

I am heading out of office for the next 3 days, reassigning.

[MelvinBot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[jliexpensify]

What a weird bug, I can repro on v88 (Pixel 3a).

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010623c6559be6640a

[MelvinBot]

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[MelvinBot]

Triggered auto assignment to @MariaHCD (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[kaushiktd]

Please re-state the problem that we are trying to solve in this issue.

Android - App adds additional letters after selecting a suggested emoji and pressing Enter(gboard)

What is the root cause of that problem ?

As per updateComment in the below file
https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionCompose.js#L518
if you are updating emojis using : ear : (start and end with colon without space) it will show proper emojis without any additional letters but if you are updating :ear (only start with colon and select from suggestion list), it will update
as an emoji icon + ear like (👂 ear )
It will show the additional letter if you are updating emojis without closing colon like (:ear)

What changes do you think we should make in order to solve the problem?

For this issue, you need to create a platform specific java file to reset the keyboard input value.
Download the file from the below path or create a new file RNTextInputResetPackage.java and RNTextInputResetModule.java in the below mention path:
Expensify/android/app/src/main/java/com/expensify/chat/

Download from here:
https://drive.google.com/file/d/1C6i56Cq3QE-rkUBHMz17gx2OjtGEQDcY/view?usp=share_link
https://drive.google.com/file/d/1vPZJRIV6qLQCoMAlfEshJ9qvCm5V-KAB/view?usp=share_link

You need to add the package name in mentioned file:
https://github.com/Expensify/App/blob/main/android/app/src/main/java/com/expensify/chat/MainApplication.java#L41
packages.add(new RNTextInputResetPackage());

Now call the native module to react native files:
Replace below file code:
https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionCompose.js#L3-L8

Import {
    View,
    TouchableOpacity,
    InteractionManager,
    LayoutAnimation,
     NativeModules,
    findNodeHandle
} from 'react-native';
const { RNTextInputReset } = NativeModules;

Now call the native module to clear the keyboard input value, add
RNTextInputReset && RNTextInputReset.resetKeyboardInput(findNodeHandle(this.textInput));

after this.updateComment() in below file:
https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionCompose.js#L448

Video file:
https://drive.google.com/file/d/1k-AxB0Cz3N4JXefvskyuLnck7zELukyL/view?usp=share_link

[mollfpr]

I can reproduce it with the Pixel 2 simulator but not the SM Flip 3 physical device.

---

@kaushiktd I try your solution, but it's still not working, and your proposal does not explain why selecting the emoji with :jo or :ea is adding the text again but not with :joy or :ear.

Here I'm applying your solution.

Screen.Recording.2023-03-23.at.23.34.12.mov

[kaushiktd]

@mollfpr See the video here,
https://drive.google.com/file/d/1e1zo_yAowYTd9pIuR4YmEUGm3MNn9BkQ/view?usp=share_link

[mollfpr]

@kaushiktd Have you try with :jo or :ea like in my video?

[kaushiktd]

@mollfpr You are correct. Will come up with a new solution. Thanks.

[kaushiktd]

PR is ready for review @johnmlee101 @mollfpr

[abekkala]

Looks like PR was deployed to staging yesterday.

@johnmlee101 should that have triggered the auto-update to the title for payment date?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove additional letters #18837

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/286211

[kaushiktd]

Any update on this, @mollfpr @johnmlee101 ?

[mollfpr]

If no regressions arise, payment will be issued on 2023-05-25. 🎊

@kaushiktd Hang tight!

[abekkala]

@mollfpr can you also complete the checklist above? that will need to be done prior to payment being made

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

It is a bug, but it's not reproduced in all Android devices, and no offending PR is causing this issue.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Since it's not reproduced in all Android devices, we can't catch this kind of bug in our development process.

[@mollfpr] Determine if we should create a regression test for this bug.

I'm inclined to have this regression test.

[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Propose regression test

1. Open the App
2. Navigate to any existing chat
3. type :sm and select emojis from the suggested list
4. Press the return / enter button from the keyboard.
5. Verify that the composer input added a new line and that no text was added after the emoji
6. 👍 or 👎

[abekkala]

Payments to be made on May 25:

• Issue reported by: @dhanashree-sawant [$250]
• Selected Proposal for fix: @kaushiktd [$2000] + [no bonus]
• C+ Review: @mollfpr [$2000] + [no bonus]

[kaushiktd]

Any update on this so far? @mollfpr @abekkala

the job has not been awarded to me yet! Just for your info. Not sure if you usually award the job at the time of making a payment

[mollfpr]

@abekkala will proceed with the payment when they are online.

[kaushiktd]

But I have not been assigned the job on Upwork yet!

[mollfpr]

@kaushiktd Me neither! Only CME/BZ can create the job and proceed the payment, so wait patiently until they are online.

[abekkala]

All offers were sent - once accepted I'll pay them! 🎉

[abekkala]

@dhanashree-sawant paid and contract ended. Thank you! 🎉

[abekkala]

@kaushiktd paid and contract ended. Thank you! 🎉

[mollfpr]

@abekkala accepted 🎉

[abekkala]

@mollfpr paid and contract ended. Thank you! 🎉
Closing!