[HOLD for payment 2023-11-30] [$250] Migrate AvatarWithImagePicker.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/AvatarWithImagePicker.js
  • type: React.Component
  • has state values: true
  • has refs: false
  • has context: false
  • lifecycle methods: componentDidMount,componentWillUnmount,componentDidUpdate

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d53fbc9f79a94c05
• Upwork Job ID: 1707284642930675712
• Last Price Increase: 2023-09-28

[MelvinBot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

This issue has not been updated in over 14 days. eroding to Weekly issue.

[muxriddinmuqimov77]

I'd like to work on this issue

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[olexyt]

I can work on this issue.

[rayane-d]

Can I work on this issue?

[mkhutornyi]

I'd like to work on this.

[ghost]

dibs?

[jczekalski]

Hey! I’m from Software Mansion, an expert agency, and I’d like to work on this issue.

[ishpaul777]

Dibs

[ghost]

Dibs. Please give me 1 issue please

[Youhy]

I can work on this issue

[joeysherman]

@eVoloshchak So from what I'm understanding, we need to change from a react class to a function component utilizing the function component paradigms for state, effects and lifecycle methods. While keeping the same functionality. Pretty straightforward 😀

I'll create a expensify account in the morning.
Applied on Upwork here's my profile - upwork.com/freelancers/~01c18ef089038ec853

[melvin-bot]

📣 @joeysherman! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[blazejkustra]

@mountiny Could you give me a bit of context why the previous PR was closed and the issue got reassigned?

Progress of the original PR is still blocked due to this (Form refactor issue), and until Form isn't refactored in WorkspaceSettingsPage, AvatarWithImagePicker as a functional component causes app to crash.

[melvin-bot]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mountiny]

BTW, discussed ith @blazejkustra 1:1, it was because it was stale. new approach showed we can create a new pr

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• updated to function component #28625

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @eVoloshchak does not require payment (Eligible for Manual Requests)
• @keisyrzk requires payment

[eVoloshchak]

This is ready for payment, @mountiny, could you post a payment summary please?

[mountiny]

@eVoloshchak getting $250 for review and testing. Since paid through newDot, I am going to close this issue now. @eVoloshchak can you note here when you request the reward in ND?

[eVoloshchak]

Requested the payment, thx!

[JmillsExpensify]

$250 payment approved for @eVoloshchak based on comment above.