Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-06-19] [$250] Migrate BigNumberPad.js to function component #16120

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 60 comments
Closed
1 task

[HOLD for payment 2023-06-19] [$250] Migrate BigNumberPad.js to function component #16120

marcaaron opened this issue Mar 20, 2023 · 60 comments
Assignees
@johncschuster @luacmartins @thesahindia @mkhutornyi
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c285211ad303e051
  • Upwork Job ID: 1664696501929406464
  • Last Price Increase: 2023-06-02
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@PauloGasparSv PauloGasparSv self-assigned this Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@PauloGasparSv PauloGasparSv added the Weekly KSv2 label Mar 22, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 31, 2023
@PauloGasparSv
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Mar 31, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2023
@PauloGasparSv
Copy link
Contributor

Still on hold, not overdue.

@melvin-bot melvin-bot bot removed the Overdue label Apr 10, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate BigNumberPad.js to function component [HOLD][$250] Migrate BigNumberPad.js to function component Apr 13, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 19, 2023
@PauloGasparSv
Copy link
Contributor

This is still on HOLD so not overdue.

@melvin-bot melvin-bot bot removed the Overdue label Apr 19, 2023
@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@PauloGasparSv
Copy link
Contributor

No updates, still on hold

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2023
@melvin-bot melvin-bot bot added the Overdue label May 10, 2023
@PauloGasparSv
Copy link
Contributor

No updates, still on hold

@melvin-bot melvin-bot bot removed the Overdue label May 10, 2023
@melvin-bot melvin-bot bot added the Overdue label May 19, 2023
@PauloGasparSv
Copy link
Contributor

No updates here

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2023
@melvin-bot melvin-bot bot added the Overdue label May 29, 2023
@PauloGasparSv
Copy link
Contributor

No updates here

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2023
@marcaaron marcaaron added the Daily KSv2 label Jun 2, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 19, 2023
@johncschuster
Copy link
Contributor

@mkhutornyi bump!

@melvin-bot melvin-bot bot added the Overdue label Jun 22, 2023
@luacmartins
Copy link
Contributor

waiting on payment

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 23, 2023
@luacmartins
Copy link
Contributor

luacmartins commented Jun 26, 2023 •
edited
Loading

Still waiting on payment. @mkhutornyi it seems like you need to apply to the job!

@melvin-bot melvin-bot bot removed the Overdue label Jun 26, 2023
@johncschuster
Copy link
Contributor

I've bumped @mkhutornyi in Slack 👍

@melvin-bot melvin-bot bot added the Overdue label Jun 30, 2023
@johncschuster
Copy link
Contributor

I haven't heard from @mkhutornyi.

@thesahindia, I've just issued payment to you. Sorry for bottlenecking payment while waiting on contact from @mkhutornyi. I didn't need to wait to issue your payment.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 30, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 3, 2023

@johncschuster, @luacmartins, @thesahindia, @mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!

@luacmartins
Copy link
Contributor

@johncschuster are we still waiting on @mkhutornyi?

@melvin-bot melvin-bot bot removed the Overdue label Jul 4, 2023
@johncschuster
Copy link
Contributor

Yep! We're waiting on @mkhutornyi to join the job so I can pay them on Upwork.

@melvin-bot melvin-bot bot added the Overdue label Jul 7, 2023
@johncschuster
Copy link
Contributor

Bump!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 7, 2023
@johncschuster
Copy link
Contributor

@mkhutornyi bump!

@melvin-bot melvin-bot bot removed the Overdue label Jul 10, 2023
@mkhutornyi
Copy link
Contributor

Sorry for late. @johncschuster
I was on vacation.
I will apply to job today.
Thanks.

@mkhutornyi
Copy link
Contributor

Hi, @johncschuster
I just send my proposal via upwork.
Thanks.

@johncschuster
Copy link
Contributor

Thanks for sending that proposal, @mkhutornyi! I've just sent the offer. Please ping me when you've accepted so I can issue payment. Thank you!

@mkhutornyi
Copy link
Contributor

Thanks for sending that proposal, @mkhutornyi! I've just sent the offer. Please ping me when you've accepted so I can issue payment. Thank you!

Accepted your offer.
Thanks.

@johncschuster
Copy link
Contributor

Payment has been issued! I think we can close this one up. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johncschuster johncschuster

@luacmartins luacmartins

@thesahindia thesahindia

@mkhutornyi mkhutornyi

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement.
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests