[HOLD for payment 2023-06-19] [$250] Migrate IOUConfirmationList.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/IOUConfirmationList.js
  • type: React.Component
  • has state values: true
  • has refs: false
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

[luacmartins]

on hold

[marcaaron]

@luacmartins taking this issue off HOLD as per this Slack post

IMPORTANT: If anything unexpected pops up during the refactor/review:

• Take it to #expensify-open-source to get clarification on.
• Prefix the conversation with [HOOK REFACTOR] so that we can find it easily.
• Link the result of the conversation in this section of the Design Doc titled “Best Practices Conversations”
• Add it to the STYLE.md guide in this open PR so we can reference it and apply any teachings in the next phase

[luacmartins]

Cool! Thanks for letting me know. I’ll work on it some time next week.

[luacmartins]

We are refactoring this component as part of a manual requests issue, so I'll wait a bit to migrate it after we merge those changes.

[luacmartins]

No updates. I'm working on Manual Requests as my top priority, so won't get to this for a few days.

[luacmartins]

no updates yet. focused on manual requests

[luacmartins]

no updates yet. focused on manual requests which hopefully means I can get to this next week.

[luacmartins]

no updates yet. focused on manual requests which hopefully means I can get to this next week.

[luacmartins]

Gonna work on it this week.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[luacmartins]

@stephanieelliott we just need to pay @mananjadhav for their review on this PR - #19561

[stephanieelliott]

Posted to Upwork and extended offer to @mananjadhav, please accept when you get a chance!

https://www.upwork.com/jobs/~01d2fcc4e33b3ad5f6

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [HOOK REFACTOR] MoneyRequestConfirmationList #19561

If no regressions arise, payment will be issued on 2023-06-19. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[stephanieelliott]

Reapplying the Bug label to get another BZ member to issue payment on this as I am OOO til July 30. Thanks @trjExpensify, this issue is for C+ payment only and I have already hired in Upwork -- the only thing to do here is issue payment on the 19th!

[luacmartins]

Just waiting on payment

[trjExpensify]

Just waiting on payment

Alright, alright.. I get the hint! ;)

Settled up, closing!