[$250] Migrate BaseModal.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/Modal/BaseModal.js
  • type: React.PureComponent
  • has state values: false
  • has refs: true
  • has context: true
  • lifecycle methods: componentDidMount,componentWillUnmount,componentDidUpdate

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01adcc5d2f587f2657
• Upwork Job ID: 1691866213671108608
• Last Price Increase: 2023-08-16

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[muxriddinmuqimov77]

I'd like to work on this issue

[s-alves10]

I'd love to work on this.

[dayana7204]

I am ready to work on this ticket. :)

[olexyt]

I can work on this issue.

[rayane-djouah]

Can I work on this issue?

[mejed-alkoutaini]

I'm able to work on this if needed!

[mkhutornyi]

I'd like to work on this.

[JKobrynski]

Hi, I'm Julian from Callstack - expert contributor group - and I would like to take a look at this issue

[melvin-bot]

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01adcc5d2f587f2657

[danielsmage1]

I have pushed a PR of this issue.
#25163

[melvin-bot]

📣 @danielsmage1! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[danielsmage1]

Contributor details
Your Expensify account email: rubyshine72@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01b76d02e87d551248

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[Gonals]

@JmillsExpensify, @marcaaron, @rushatgabhane, I got assigned @danielsmage1's PR for review, but it doesn't look like we have a C+ approved proposal from him in this issue. Is that something we are not doing for this migration?

[marcaaron]

Hmm that's weird. It should have assigned me. @Gonals I'm just gonna take that one off your hands and you can not worry about it. Basically, for these refactors many are assigned to volunteers and some go to contributors. This one went to callstack so we don't need a C+ proposal review.

[marcaaron]

@danielsmage1 you are not assigned to the issue. Please read the contributing guidelines.

[JKobrynski]

A draft PR has been published for internal review

[JKobrynski]

The PR is ready for review!

[melvin-bot]

@JmillsExpensify, @marcaaron, @JKobrynski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@JmillsExpensify, @marcaaron, @JKobrynski Still overdue 6 days?! Let's take care of this!

[melvin-bot]

This issue has not been updated in over 14 days. @JmillsExpensify, @marcaaron, @JKobrynski eroding to Weekly issue.

[melvin-bot]

This issue has not been updated in over 15 days. @JmillsExpensify, @marcaaron, @JKobrynski eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[JmillsExpensify]

It looks like the PR is merged right? Is all that's left here is paying @s77rt for the PR review?

[JmillsExpensify]

In fact, it might be @parasharrajat as well? All in all, I'd love a summary on where we're at.

[s77rt]

@JmillsExpensify I didn't review that PR

[parasharrajat]

@JmillsExpensify No C+ reviewed the PR. We are shown as reviewers because we commented on the PR to mention regressions.

[JmillsExpensify]

Thanks! @marcaaron @JKobrynski can you help clarify whether there is anything else left to do here?

[JmillsExpensify]

Closing to clear this one. Please re-open if there is anything left to do.