[HOLD for payment 2023-09-08] [$250] Migrate index.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/SignInPageForm/index.js
  • type: React.Component
  • has state values: false
  • has refs: true
  • has context: false
  • lifecycle methods: componentDidMount,componentWillUnmount

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0139e2c951f46681da
• Upwork Job ID: 1685092318042664960
• Last Price Increase: 2023-07-29
• Automatic offers:
• rayane-djouah | Contributor | 25889648

[s-alves10]

I'd love to work on this.

[dayana7204]

I am ready to work on this ticket. :)

[melvin-bot]

📣 @dayana7204! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[vdem0115]

I would like to work on this issue.

[olexyt]

I can work on this issue.

[rayane-djouah]

Can I work on this?

[mejed-alkoutaini]

I'm able to work on this if needed!

[melvin-bot]

Triggered auto assignment to @sakluger (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0139e2c951f46681da

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[melvin-bot]

Triggered auto assignment to @deetergp, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @0xmiroslav We're missing your Upwork ID to automatically send you an offer for the Reviewer role.
Once you apply to the Upwork job, your Upwork ID will be stored and you will be automatically hired for future jobs!

[melvin-bot]

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[rayane-djouah]

Thank you! I will rise a PR shortly

[rayane-djouah]

@0xmiroslav PR is ready for review 🚀

[rayane-djouah]

Waiting for @0xmiroslav review

[rayane-djouah]

@0xmiroslav any updates?

[sakluger]

Looks like @0xmiroslav reviewed and requested changes a few days ago.

[rayane-djouah]

changes are made, could you take a look @0xmiroslav

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @rayane-djouah got assigned: 2023-08-01 21:55:51 Z
• when the PR got merged: 2023-08-31 16:26:19 UTC
• days elapsed: 21

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate SignInPageForm/index.js to function component #24027

If no regressions arise, payment will be issued on 2023-09-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment offer (Contributor)
• @0xmiroslav requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[rayane-djouah]

@sakluger friendly bump for payment

[sakluger]

Really sorry for the delay! Not sure why this wasn't switched back to daily.

Summarizing payouts for this issue:

Contributor: @rayane-djouah $250 (hired and paid via Upwork)
Contributor+: @0xmiroslav $250 (payable via Manual Request after BZ checklist is completed)

@0xmiroslav I'm going to close the issue, please request payment via NewDot manual request.

[0xmiros]

This is migration. Not require BZ checklist