[HOLD for payment 2023-10-10] [$250] Migrate EnablePaymentsPage.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/EnablePayments/EnablePaymentsPage.js
  • type: React.Component
  • has state values: false
  • has refs: false
  • has context: false
  • lifecycle methods: componentDidMount,componentDidUpdate

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017ab9b594d07f40d3
• Upwork Job ID: 1706589056505331712
• Last Price Increase: 2023-09-26

[MelvinBot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[s-alves10]

I'd love to work on this.

[dayana7204]

I am ready to work on this ticket. :)

[vdem0115]

I would like to work on this issue.

[KrAbhas]

I would like to work on this.

[olexyt]

I can work on this issue.

[rayane-djouah]

Can I work on this?

[to-ai]

I am able to work on this task.

[barttom]

Hello!
I'm Bartek from Callstack - an expert contributor group and I would like to work on this one.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017ab9b594d07f40d3

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[ghost]

Dibs

[petromoldovan]

dibs

[melvin-bot]

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

@stitesExpensify I already got autoassigned this one, I'll swap out for you

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor/16232/migration enable payments page to function component #28236

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @barttom does not require payment (Contractor)
• @jjcoffee requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

@dangrous, @barttom, @jjcoffee 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mallenexpensify]

@jjcoffee can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~017ab9b594d07f40d3

[dangrous]

No bug checklist needed on this, and I believe we just need payment for @jjcoffee since @barttom is handled separately - do I have that right? cc @mallenexpensify

[jjcoffee]

@mallenexpensify Accepted, thanks for stepping in here!

[mallenexpensify]

Contributor: @barttom is due $250 via Call Stack
Contributor+: @jjcoffee paid $250 via Upwork.

I don't think we're paying urgency bonuses for refactors, I did a quick search in Slack but didn't find anything. Comment if you disagree, bonus points for linking to somewhere that says we are.