[HOLD for payment 2023-07-14] [$250] Migrate NewChatPage.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/pages/NewChatPage.js
  • type: React.Component
  • has state values: true
  • has refs: false
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013e875c428c833da0
• Upwork Job ID: 1664707231797780480
• Last Price Increase: 2023-06-02

[marcaaron]

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

[thienlnam]

Thanks @marcaaron! I will have to counter your offer, unfortunately I can only do this for the original $1000. Thank you for your consideration and please let me know

[marcaaron]

👢

[marcaaron]

Heads up, I'm taking this issue off HOLD and making it a Daily. If you are unable to work on it please remove your assignment and add the External + Help Wanted labels as per this update.

[Nikhil-Vats]

Hey @thienlnam 👋, I can take this up if you don't have time for this.

[thienlnam]

Thanks for the ping, that would be great actually

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013e875c428c833da0

[melvin-bot]

Triggered auto assignment to @twisterdotcom (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Current assignee @thienlnam is eligible for the External assigner, not assigning anyone new.

[multijump]

I would like to take this issue

[melvin-bot]

📣 @Nikhil-Vats You have been assigned to this job by @thienlnam!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @multijump! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[greg-schroeder]

C+ review is complete, waiting on @thienlnam to confirm and merge I believe

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @Nikhil-Vats got assigned: 2023-06-02 18:55:42 Z
• when the PR got merged: 2023-07-03 19:28:34 UTC
• days elapsed: 21

On to the next one 🚀

[thienlnam]

Just merged!

[greg-schroeder]

Awaiting deploy to prod

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Migrate NewChatPage to functional component #20170

If no regressions arise, payment will be issued on 2023-07-14. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom / @greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[twisterdotcom]

@aimane-chnaif not listed here: https://github.com/Expensify/Web-Expensify/blob/main/_devportal/lib/KernelScheduling/Data.php#L242.

Sending Upwork offer: https://www.upwork.com/en-gb/nx/wm/pre-hire/c/8577561/offer/25535772

@Nikhil-Vats - Upwork offer here: https://www.upwork.com/en-gb/nx/wm/pre-hire/c/8577561/offer/25535788

[Nikhil-Vats]

Accepted @twisterdotcom

[aimane-chnaif]

@aimane-chnaif not listed here: https://github.com/Expensify/Web-Expensify/blob/main/_devportal/lib/KernelScheduling/Data.php#L242.

What list is there?

Edit: Ah, I assume newDot payment

[twisterdotcom]

Yes sorry, it's the newDot payment one. Just for my own sanity @aimane-chnaif!

[twisterdotcom]

Paid out!