Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-06-13] [$1000] Infinite loading while opening Concierge deeplink #16319

Closed
1 of 6 tasks
kavimuru opened this issue Mar 20, 2023 · 48 comments
Closed
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

kavimuru commented Mar 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login with any account.
  2. Send staging.new.expensify.com/concierge in a message with another user.
  3. Click on that deep link, go back by pressing left arrow in the browser.
  4. Click to the deep link again, and go back again.
  5. Click the deep link a third time and go back again.
  6. Click the link a fourth time and notice that the screen is loading infinitely after that.

Expected Result:

It should show Concierge screen in stead of infinite loading.

Actual Result:

The screen is loading infinitely after opening deep link from Report.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.87-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2023-03-20.at.22.27.11.mov
Recording.133.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679326193585419

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0104b35fc677f8192d
  • Upwork Job ID: 1638557184113455104
  • Last Price Increase: 2023-03-22
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@MelvinBot
Copy link

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Mar 20, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@joekaufmanexpensify
Copy link
Contributor

I'm not able to reproduce this on my end. Posted in Slack. Closing for now.

@joekaufmanexpensify
Copy link
Contributor

Okay tried again after discussing in Slack, and was able to reproduce. Updated reproduction steps above.

2023-03-21_08-42-08 (1)

@joekaufmanexpensify
Copy link
Contributor

Assigning to engineering for confirmation that this can be external!

@MelvinBot
Copy link

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Expensify Expensify unlocked this conversation Mar 21, 2023
@madmax330
Copy link
Contributor

Yeah I think this issue can be external

@joekaufmanexpensify joekaufmanexpensify added the External Added to denote the issue can be worked on by a contributor label Mar 22, 2023
@joekaufmanexpensify
Copy link
Contributor

Awesome, thanks!

@melvin-bot melvin-bot bot changed the title Infinite loading while opening Concierge deeplink [$1000] Infinite loading while opening Concierge deeplink Mar 22, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~0104b35fc677f8192d

@MelvinBot
Copy link

Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 22, 2023
@MelvinBot
Copy link

Current assignee @madmax330 is eligible for the External assigner, not assigning anyone new.

@koko57
Copy link
Contributor

koko57 commented Mar 23, 2023

hello :) I can take a look

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 23, 2023
@MelvinBot
Copy link

📣 @koko57 You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@joekaufmanexpensify
Copy link
Contributor

Sounds great, thanks @koko57 ! Let us know if there's anything we can help with.

@joekaufmanexpensify
Copy link
Contributor

Same

@joekaufmanexpensify
Copy link
Contributor

Still on hold

@joekaufmanexpensify
Copy link
Contributor

Same

@joekaufmanexpensify
Copy link
Contributor

On hold

@joekaufmanexpensify
Copy link
Contributor

Same

@joekaufmanexpensify
Copy link
Contributor

Still on hold.

@joekaufmanexpensify
Copy link
Contributor

Same

@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@madmax330
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2023
@koko57
Copy link
Contributor

koko57 commented Jun 7, 2023

Hi @mountiny! I've noticed that #19263 is already merged.I'll be OOO until the end of this week, but I'll check into this issue when I return on Monday.

@mountiny
Copy link
Contributor

mountiny commented Jun 7, 2023

Great, thank you @koko57!

@koko57
Copy link
Contributor

koko57 commented Jun 12, 2023

@mountiny I cannot reproduce nor the main issue (following the steps to reproduce) neither the one I've found while investigating this one:

I’ve also found another issue - when navigating through the chat channels and then going back every time we go back we skip one channel (video).

[tested locally and on the prod]

Seems to be fixed by the navigation refactor 😃

@mountiny
Copy link
Contributor

Amazing, thank you!

@mountiny mountiny reopened this Jun 12, 2023
@mountiny
Copy link
Contributor

Need to pay for reporting this to @hungvu193 $250 cc @joekaufmanexpensify

@mountiny mountiny changed the title [HOLD #11768] [$1000] Infinite loading while opening Concierge deeplink [HOLD for payment 2023-06-13] [$1000] Infinite loading while opening Concierge deeplink Jun 12, 2023
@mountiny mountiny added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 12, 2023
@joekaufmanexpensify
Copy link
Contributor

Okay, chatted with Vit and confirmed this bug was fixed by a PR from the navigation refactor. So the only payment we need to make is $250 to @hungvu193 for reporting.

@joekaufmanexpensify
Copy link
Contributor

Original upwork job is closed for inactivity, so opening a new one!

@joekaufmanexpensify
Copy link
Contributor

new upwork job is here

@joekaufmanexpensify
Copy link
Contributor

@hungvu193 offer sent for $250!

@hungvu193
Copy link
Contributor

Thanks @joekaufmanexpensify, I've just accepted!

@joekaufmanexpensify
Copy link
Contributor

@hungvu193 $250 sent and contract ended!

@joekaufmanexpensify
Copy link
Contributor

Upwork job closed.

@joekaufmanexpensify
Copy link
Contributor

Closing as this is all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

8 participants