Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-13] Gyroscope-driven animations of empty chats #16366

Closed
3 tasks
thienlnam opened this issue Mar 21, 2023 · 40 comments
Closed
3 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@thienlnam
Copy link
Contributor

thienlnam commented Mar 21, 2023

Proposal

Hackathon idea: Gyroscope-driven animations of empty chats

We've decided to move forward with this project
https://expensify.slack.com/archives/C01GTK53T8Q/p1678998169743399

Tasks

  • Host a pre-design meeting (example) in #expensify-open-source to discuss any necessary details in public before filling out the High-level of proposed solution section.
  • Host another pre-design meeting in #expensify-open-source to ask for engineering feedback on the technical solution.
  • Implement the changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c2abcbce4ff7d670
  • Upwork Job ID: 1683848756747649024
  • Last Price Increase: 2023-07-25
@thienlnam thienlnam added Daily KSv2 NewFeature Something to build that is a new item. labels Mar 21, 2023
@roryabraham
Copy link
Contributor

Thanks for creating an issue @thienlnam. Going to make this a weekly though

@roryabraham roryabraham added Weekly KSv2 and removed Daily KSv2 labels Mar 22, 2023
@melvin-bot melvin-bot bot added the Overdue label Mar 31, 2023
@roryabraham
Copy link
Contributor

No update this week – waiting on some bug fixes in Reanimated.

@melvin-bot melvin-bot bot removed the Overdue label Mar 31, 2023
@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2023
@roryabraham
Copy link
Contributor

Got some feedback from SWM team on this PR, should be able to pick it back up now.

@melvin-bot melvin-bot bot removed the Overdue label Apr 19, 2023
@melvin-bot melvin-bot bot added the Overdue label May 1, 2023
@roryabraham
Copy link
Contributor

No update this week. Still on my mind, maybe a good one for a Saturday morning 🙂

@melvin-bot melvin-bot bot removed the Overdue label May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 19, 2023
@roryabraham
Copy link
Contributor

Tried working on this again today, found that the sensor has a very different orientation on Android v.s: Android Chrome (which provided sensor data out of the box w/o requiring additional permissions)

@melvin-bot melvin-bot bot removed the Overdue label May 24, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 1, 2023
@roryabraham
Copy link
Contributor

No update right now.

@melvin-bot melvin-bot bot removed the Overdue label Jun 1, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 9, 2023
@roryabraham
Copy link
Contributor

Waiting for an update from the Reanimated team in the PR

@melvin-bot melvin-bot bot removed the Overdue label Jun 10, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 19, 2023
@roryabraham
Copy link
Contributor

No update

@melvin-bot melvin-bot bot removed the Overdue label Jun 19, 2023
@melvin-bot melvin-bot bot added the Overdue label Jun 27, 2023
@roryabraham
Copy link
Contributor

No update since #16004 (comment) – Gyro sensor orientations are not consistent across native platforms + mobile web browsers.

@melvin-bot melvin-bot bot removed the Overdue label Jun 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 5, 2023

This issue has not been updated in over 15 days. @mollfpr, @wojtus7, @roryabraham eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added Monthly KSv2 Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Oct 5, 2023
@melvin-bot melvin-bot bot changed the title Gyroscope-driven animations of empty chats [HOLD for payment 2023-10-13] Gyroscope-driven animations of empty chats Oct 6, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 12, 2023
@mollfpr
Copy link
Contributor

mollfpr commented Oct 15, 2023

@roryabraham Could you help adding BZ here and confirm if we need a checklist? Thanks!

@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2023
@roryabraham roryabraham added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. labels Oct 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 Overdue labels Oct 18, 2023
@roryabraham roryabraham added Daily KSv2 and removed Weekly KSv2 labels Oct 18, 2023
@roryabraham
Copy link
Contributor

@JmillsExpensify tagging you in for payment. BZ checklist is not needed since this was a new feature, not a bug

@mollfpr
Copy link
Contributor

mollfpr commented Oct 20, 2023

@JmillsExpensify Should this issue price at a 1000? Since this issue was created before the price change.

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@roryabraham
Copy link
Contributor

@JmillsExpensify bump – this is ready for payment.

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@JmillsExpensify
Copy link

Payment summary: $1,000 payment to @mollfpr for PR review.

@JmillsExpensify
Copy link

$1,000 payment approved via NewDot based on summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

7 participants