Remove AsyncStorage dependency from Onyx. Clean up tests.

[marcaaron]

After switching from AsyncStorage to react-native-quick-sqlite in Onyx we still have some tests that are using the mock storage providers from AsyncStorage. Additionally, the tests we have are a bit of a mess and don't really test the "real" implementations of storage so it doesn't really matter what we use there.

@kidroca and @chrispader started working on the clean up already so this is just an issue to track the progress.

[MelvinBot]

Huh... This is 4 days overdue. Who can take care of this?

[marcaaron]

@chrispader's working on it

[marcaaron]

This is in review

[marcaaron]

Looks like we merged the linked PR here. But we still need a PR to fix up App so it's using the latest react-native-onyx.

[marcaaron]

@chrispader is the above something you are looking into?

[chrispader]

Yes, i'm gonna create a PR that adds the latest changes to Expensify/App 👍

[chrispader]

Created this PR, which also includes later changes in react-native-onyx

[chrispader]

@marcaaron i think this issue can be closed now, right? 🎉

[marcaaron]

almost! we close issues when they are deployed to production.

[melvin-bot]

This issue has not been updated in over 15 days. @marcaaron eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[chrispader]

@marcaaron can this be closed out now? :)