Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for #12775] [$1000] Web - LHN - Preview of the last message in the conversation is not displayed after go back online #16503

Closed
1 of 6 tasks
kbecciv opened this issue Mar 25, 2023 · 28 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Monthly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Mar 25, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Login with any account
  3. Disable the internet connection in the device
  4. Click on the green + button
  5. Click on the "New Chat" option
  6. Search for a user with a valid email that you don't have any messages with and open the chat.
  7. Verify the user is navigated to the conversation
  8. Verify the conversation is grayed out indicating is pending to be created
  9. Send some messages
  10. Verify that in the left hand navigation chat list, a preview of the last message in the conversation is displayed under account B
  11. Enable the internet connection

Expected Result:

In the left hand navigation chat list, a preview of the last message in the conversation is displayed under account B after returning online

Actual Result:

After returning to the network in the left hand navigation chat list, a preview of the last message in the conversation is not displayed. You need switch to another chat to see the last message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.2.89.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5992249_Recording__391.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ade67375bc1d8d7b
  • Upwork Job ID: 1642848211738480640
  • Last Price Increase: 2023-04-03
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 25, 2023
@MelvinBot
Copy link

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@MelvinBot
Copy link

MelvinBot commented Mar 25, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Overdue label Mar 27, 2023
@MelvinBot
Copy link

@laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MelvinBot
Copy link

@laurenreidexpensify Huh... This is 4 days overdue. Who can take care of this?

@laurenreidexpensify
Copy link
Contributor

Sorry it took me so long to get to this one, have reviewed and can confirm it can be sent for external

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2023
@laurenreidexpensify laurenreidexpensify added the External Added to denote the issue can be worked on by a contributor label Apr 3, 2023
@melvin-bot melvin-bot bot changed the title Web - LHN - Preview of the last message in the conversation is not displayed after go back online [$1000] Web - LHN - Preview of the last message in the conversation is not displayed after go back online Apr 3, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01ade67375bc1d8d7b

@MelvinBot
Copy link

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 3, 2023
@MelvinBot
Copy link

Triggered auto assignment to @youssef-lr (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@koko57
Copy link
Contributor

koko57 commented Apr 3, 2023

Hi I am Agata from Callstack - expert contributor group - maybe we could help?

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 3, 2023
@MelvinBot
Copy link

📣 @koko57 You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@ShogunFire
Copy link
Contributor

@mountiny Hello, I am not sure why you assigned @koko57 without any proposal but I think this issue might be related to #12775 and might need to be put on hold.

@mountiny
Copy link
Contributor

mountiny commented Apr 3, 2023

Thanks for pointing to that issue, it will help with the investigation.

@ShogunFire For more context, we work with couple of Expert agencies who help us with new features and project but also with some bugs, especially some more complex which contributor community has not been able to resolve. We also offload some of new issues to them and the issues dont have promising proposals. That's when they have free capacity.

I hope that makes sense @ShogunFire there is still many available issues in the pool

@burczu
Copy link
Contributor

burczu commented Apr 4, 2023

Hello, I am from Callstack - expert contributor group. I would like to take care of this issue.

@mountiny mountiny assigned burczu and unassigned koko57 Apr 4, 2023
@MelvinBot
Copy link

📣 @burczu You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@mountiny
Copy link
Contributor

mountiny commented Apr 4, 2023

@burczu
Copy link
Contributor

burczu commented Apr 5, 2023

Daily update: I'm still working on this issue - seems like while we switch from offline to online, the data stored in the onyx storage is written to the backend and then the storage is cleared until it's populated back, but I didn't find why (and where) it is happening. I will dig deeper.

@mountiny
Copy link
Contributor

mountiny commented Apr 5, 2023

Might be related to the replay effect as ShogunFire mentioned above #12775 worth checking out.

@burczu
Copy link
Contributor

burczu commented Apr 6, 2023

@mountiny I've red the whole thread in #12775 and some Slack threads mentioned in this issue and I agree with you that it's most likely related. I think we should put this one on hold until the #12775 solution is implemented, which is ongoing right now, as I've seen.

This is also very similar to #13310 which is mentioned in #12775 as related (closed as a duplicate of #13250 which is also related to #12775)

@mountiny mountiny changed the title [$1000] Web - LHN - Preview of the last message in the conversation is not displayed after go back online [HOLD for #12775] [$1000] Web - LHN - Preview of the last message in the conversation is not displayed after go back online Apr 6, 2023
@mountiny
Copy link
Contributor

mountiny commented Apr 6, 2023

Thanks @burczu put this on hold cc @youssef-lr

@melvin-bot melvin-bot bot added the Overdue label Apr 10, 2023
@youssef-lr youssef-lr added the Monthly KSv2 label Apr 10, 2023
@youssef-lr
Copy link
Contributor

Thanks @burczu and @mountiny, changing to monthly based on hold.

@youssef-lr youssef-lr removed the Daily KSv2 label Apr 10, 2023
@melvin-bot melvin-bot bot removed the Overdue label Apr 10, 2023
@melvin-bot melvin-bot bot added the Overdue label May 12, 2023
@laurenreidexpensify
Copy link
Contributor

@youssef-lr does the hold still apply here?

@melvin-bot melvin-bot bot removed the Overdue label May 15, 2023
@laurenreidexpensify
Copy link
Contributor

@youssef-lr bump ^^

@mountiny
Copy link
Contributor

Seems like the replay effect should be fixed now so we should take this off hold #12775 (comment)

@youssef-lr
Copy link
Contributor

youssef-lr commented May 22, 2023

Sorry I missed your last ping @laurenreidexpensify. Yes I think it still applies, the solution this is being held on doesn't seem to have been fully implemented yet. @kbecciv Can you test if this is still in issue?

edit: after Vit's comment, looks like it's on staging.

@kbecciv
Copy link
Author

kbecciv commented May 26, 2023

@youssef-lr Sure, checking with QA team, will update you shortly!

@kbecciv
Copy link
Author

kbecciv commented May 26, 2023

@youssef-lr Issue is fixed.

Recording.641.mp4

@mountiny
Copy link
Contributor

Wohoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Monthly KSv2
Projects
None yet
Development

No branches or pull requests

9 participants